Skip to content

Delete json_tag from child components as it could cause RecursionError #736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Delete json_tag from child components as it could cause RecursionError #736

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions django_unicorn/components/unicorn_template_response.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,6 +247,11 @@ def render(self):
for child in descendant.children:
init_script = f"{init_script} {child._init_script}"
json_tags.append(child._json_tag)
# We need to delete this property here as it can cause RecursionError
# when pickling child component. Tag element has previous_sibling
# and next_sibling which would also be pickled and if they are big,
# cause RecursionError
del child._json_tag
descendants.append(child)

script_tag = soup.new_tag("script")
Expand Down