-
Notifications
You must be signed in to change notification settings - Fork 54
Add Espressif C5 devkit #835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| with: | ||
| repository: adafruit/ci-arduino | ||
| ref: ci-wippersnapper | ||
| ref: ci-wippersnapper-esp333 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we are going to use this branch, across this ci, shouldn't we merge the esp333 work into ci-wippersnapper and use that instead?
| with: | ||
| repository: adafruit/Wippersnapper_Boards | ||
| path: ws-boards | ||
| ref: add-c5devkit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this ref be removed after the boards repo PR is merged?
| - name: Rename build artifacts to reflect the platform name | ||
| run: | | ||
| mv examples/Wippersnapper_demo/build/*/Wippersnapper_demo.ino.bin wippersnapper.${{ matrix.arduino-platform }}.littlefs.${{ env.WS_VERSION }}.bin | ||
| # mv examples/Wippersnapper_demo/build/*/Wippersnapper_demo.ino.merged.bin wippersnapper.${{ matrix.arduino-platform }}.littlefs.${{ env.WS_VERSION }}.auto-merge.bin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If commenting out, please add another commented line explaining why you are commenting this out
| with: | ||
| repository: adafruit/Wippersnapper_Boards | ||
| path: ws-boards | ||
| ref: add-c5devkit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure to change this when the ws-boards branch is merged please!
This adds the C5 devkit, with 2.4GHz and 5GHz WiFi 6 support.
The C5 flashed fine with platformio but had a similar issue flashing CI assets to the C6 generated when esptool wasn't pinned. Also now that we aren't pinned for lvgl, it felt like a good time to revisit using the latest BSP and ESPtool, previously held up by the flash args issue for the C6.
Our merged bin was suggested (by Jason8266) as having the wrong flash args causing the ets loader issue when using latest esptool, and looking at the arduino-IDE output for the C5 instead it uses "keep" as the args after the initial setup of the bootloader and app partition. I thought I'd tried that before with the C6 although I might have had other issues too then.
There was a mismatch with boot mode DIO and flash mode QIO which the c5 uses, compared to our fixed merge-bin command that uses a single argument. The arduino IDE generates bootloader.bin using
esptool elf2imagefrom a qio_80m.elf bootloader, but using DIO flash mode arg to that command, even though flash mode was QIO from the FQBN string - checking deeper it needs DIO for boot flash mode)I've tested the Feather C6 and Espressif C5 devkit, using the combined.bin from CI assets after an erase. (Both now use esptool 5.1.0 instead of 4.6, with "keep" for the flash args to merge-bin, and every esp32 board is moved to BSP 3.3.3 instead of ~3.1)
Boards Repo PR:
adafruit/Wippersnapper_Boards#222
CI Arduino Branch:
https://github.com/adafruit/ci-arduino/tree/ci-wippersnapper-esp333 [Pointed at adafruit/arduino-esp32 BSP3.3.3]