Handle resource quota on status forbidden by retrying #4305
+29
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikola-jokic
added
the
gha-runner-scale-set
Contributor
|
Hello! Thank you for your contribution. Please review our contribution guidelines to understand the project's testing and code conventions. |
nikola-jokic
requested review from
a team,
rentziass and
toast-gear
as code owners
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors error handling for pod creation failures in the EphemeralRunnerReconciler. It splits the handling of IsInvalid and IsForbidden errors and introduces special recovery logic for resource quota exceeded scenarios.
Key Changes:
- Separated
IsInvalidandIsForbiddenerror handling into distinct cases - Added resource quota exceeded detection with retry logic
- Implemented automatic ephemeral runner recreation when quota is exceeded and runner is about to expire
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request improves error handling and logging in the
EphemeralRunnerReconcilerfor pod creation failures, particularly distinguishing between invalid and forbidden errors, and adding logic to handle resource quota issues more gracefully.Error handling improvements:
IsInvalidpod creation errors by logging the error and marking theEphemeralRunneras failed, instead of treating it together withIsForbiddenerrors.IsForbiddenerrors by checking if the error is due to resource quota being exceeded. If the quota is exceeded and the runner is about to expire, the ephemeral runner is deleted and recreated; if only the quota is exceeded, the reconcile is retried after 30 seconds. Other forbidden errors fall back to the default handling.Fixes #3629