Skip to content

Conversation

@tsuna
Copy link

@tsuna tsuna commented Sep 17, 2025

When running DinD it's common to need a lower MTU on the nested Docker bridge.

Use a default of 1450 as it's generally safer than not doing anything, and pretty harmless if done when not needed.

@tsuna
Copy link
Author

tsuna commented Sep 26, 2025

Ping. Please :)

Copilot AI review requested due to automatic review settings October 15, 2025 20:47
@tsuna tsuna requested a review from a team as a code owner October 15, 2025 20:47
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds MTU configuration support for the nested Docker daemon when running in DinD (Docker-in-Docker) mode. The change allows users to customize the MTU setting for better network compatibility in nested container environments, with a safe default of 1450.

Key Changes:

  • Added MTU configuration option for DinD mode with a default value of 1450
  • Updated Helm chart template to pass MTU setting to dockerd command

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
charts/gha-runner-scale-set/values.yaml Added documentation for the new containerMode.dind.mtu configuration option
charts/gha-runner-scale-set/templates/_helpers.tpl Added --mtu flag to dockerd arguments with configurable value

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

# containerMode:
# type: "dind" ## type can be set to "dind", "kubernetes", or "kubernetes-novolume"
# dind:
# mtu: 1450 ## Optional. Defaults to 1450 in DinD mode
Copy link

Copilot AI Oct 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The comment states 'Defaults to 1450 in DinD mode' but doesn't clarify what happens in non-DinD modes. Consider clarifying that this setting only applies when type: \"dind\" is set, or that it has no effect in other modes.

Suggested change
# mtu: 1450 ## Optional. Defaults to 1450 in DinD mode
# mtu: 1450 ## Optional. Only applies when containerMode.type is "dind". Defaults to 1450 in DinD mode. Has no effect in other modes.

Copilot uses AI. Check for mistakes.
When running DinD it's common to need a lower MTU on the nested
Docker bridge.
@benoit-nexthop
Copy link

@Draco7587 you approved this change 3 weeks ago but some workflows remained waiting for approval. Would it be possible to let those run so this PR can merge? Thanks in advance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants