Native ESM #137
Open
Native ESM #137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettz9
force-pushed
the
esm
branch
3 times, most recently
from
866d709 to
c027657
Compare
…orn) Also: - fix: pass attw validation
…JS module by rollup.
Removes unneeded devDeps. and `module` property; switches to cjs extension for CommonJS build
Contributor
Author
|
I've merged in and built on changes added in #139 since that PR is more critical, and also shapes how this one is formed. But this one is also important for ESM types (and also simplifying browserification). I'd be happy to explain any of the changes in further detail, as I've gained a much better understanding of TypeScript since my earlier PR. |
|
Would be great to get native ESM support into this project! Been maintaining an ESM fork for a bit so would be great to archive / deprecate that one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on #113 to complete the work there and switch to native ESM support, now that it is available in Node.