Skip to content

Update Ajax Filter JS #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update Ajax Filter JS #7

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f9e7102
Update Click Event Binding
natedawg92 Jun 30, 2020
b326767
Apply Bindings after Ajax Content Update
natedawg92 Jun 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 20 additions & 16 deletions view/frontend/web/js/product/list/ajax-filter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ define([
*/
options:
{
links: 'a:not([data-ajax=false])', // all links except those configured
links: 'a:not([data-ajax=false])[href]', // all links except those configured
// with a 'data-ajax="false"' attribute
contentContainer: '.column.main',
sidebarMainContainer: '.sidebar-main',
Expand All @@ -40,7 +40,7 @@ define([
* @return void
*/
_create: function () {
this._bind($(this.element).find(this.options.links));
this._bind($(this.element));
},

/**
Expand All @@ -50,9 +50,7 @@ define([
* @return void
*/
_bind: function (element) {
if (element.is('a')) {
element.on('click', $.proxy(this.processLink, this));
}
element.on('click', $.proxy(this.processLink, this));
},

/**
Expand All @@ -62,10 +60,12 @@ define([
* @return void
*/
processLink: function (event) {
event.preventDefault();
this.ajaxSubmit($(event.currentTarget).attr('href'));
if ($(event.target).closest('a').is(this.options.links)) {
event.preventDefault();
this.ajaxSubmit($(event.target).closest('a').attr('href'));
}
},

/**
* Update content and init all components defined via the data-mage-init
* attribute
Expand All @@ -74,24 +74,28 @@ define([
* @return void
*/
updateContent: function (html) {
if (html.content) {
if (html.content) {
// Remove all products wrappers except the first one
$(this.options.contentContainer).slice(1).remove();

// Update content
$(this.options.contentContainer)
.html(html.content)
.trigger('contentUpdated');
.trigger('contentUpdated')
.children()
.applyBindings();
}

if (html.sidebar_main) {
$(this.options.sidebarMainContainer)
.empty()
.html(html.sidebar_main)
.trigger('contentUpdated');
.trigger('contentUpdated')
.children()
.applyBindings();
}
},

/**
* Replace the browser URL
*
Expand All @@ -107,7 +111,7 @@ define([
history.replaceState(null, null, url);
}
},

/**
* Scroll to the top of the content container and update content
*
Expand Down Expand Up @@ -137,7 +141,7 @@ define([
*/
ajaxSubmit: function (url) {
var self = this;

$.ajax({
url: url,
data: 'ajax=1',
Expand Down