Fix: Accept "beta" as valid WordPress version in CLI validation #2820
+177
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: adamziel <205419+adamziel@users.noreply.github.com>
Co-authored-by: adamziel <205419+adamziel@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix message for invalid WordPress version in CLI
Fix: Accept "beta" as valid WordPress version in CLI validation
Oct 25, 2025
Copilot finished work on behalf of
adamziel
October 25, 2025 15:17
fellyph
reviewed
Oct 25, 2025
| } catch { | ||
| throw new Error( | ||
| 'Unrecognized WordPress version. Please use "latest", a URL, or a numeric version such as "6.2", "6.0.1", "6.2-beta1", or "6.2-RC1"' | ||
| 'Unrecognized WordPress version. Please use "latest", "beta", "trunk", "nightly", a URL, or a numeric version such as "6.2", "6.0.1", "6.2-beta1", or "6.2-RC1"' |
Collaborator
There was a problem hiding this comment.
@adamziel I think the point is here, the conditional check if the version is valid, if not skip it and doesn't do anything. I think we should throw a message if the value is not valid
if (args.wp !== undefined && !isValidWordPressSlug(args.wp)) {
try {
// Check if is valid URL
new URL(args.wp);
} catch {
throw new Error(
'Unrecognized WordPress version. Please use "latest", "beta", "trunk", "nightly", a URL, or a numeric version such as "6.2", "6.0.1", "6.2-beta1", or "6.2-RC1"'
);
}
}
```
Contributor
Author
There was a problem hiding this comment.
The validation code is correct and already throws an error for invalid WordPress versions. My fix (commit abc3a4a) adds "beta" to the list of valid versions and improves the error message to clearly list all supported formats.
The code now:
- ✓ Accepts
--wp=betaas valid (previously rejected) - ✓ Rejects invalid versions like
--wp=brazilwith error: "Unrecognized WordPress version. Please use "latest", "beta", "trunk", "nightly", a URL, or a numeric version..." - ✓ The validation happens in the
.check()callback, which yargs calls before executing the command
Note: If users mistakenly use --version= instead of --wp=, yargs with strictOptions() should reject it as an unknown option.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CLI validation regex rejected
--wp=betadespiteresolveWordPressRelease()supporting it. Users attempting to test beta versions received an unhelpful error that didn't list all valid options.Changes
betato the regex pattern inisValidWordPressSlug()latest,beta,trunk,nightlyBefore/After
Invalid versions like
brazilare still rejected, now with clearer guidance on valid formats.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
download.cypress.ionode index.js --exec install(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.