PcapNG: Rewrite hexpat for bugfixing #462
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoniovazquezblanco
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was debugging a piece of code that writes PcapNG files to disk. I noticed that the hexpat in ImHex was not correctly parsing custom blocks due to padding and size issues.
I started working on fixing this and realized the file was a bit too repetitive and was doing padding calculations in many places and coud be simplified. I got carried out and rewrote the file to use std::mem::AlignTo whenever needed and to recycle fields instead of replicating them in many places.
After some testing with my files I can confirm that my parsing issues were solved but I have not deeply tested Options parsing (my files do not have that section) although it should be ok.
I hope this is of your liking.
Thanks