Skip to content

add flag to disable startup setlocal indent #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

add flag to disable startup setlocal indent #80

wants to merge 1 commit into from

Conversation

@aykamko
Copy link

@aykamko aykamko commented Jul 27, 2017

No description provided.

blueyed
blueyed reviewed Jul 27, 2017
View reviewed changes
README.rst
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

By default, this plugin sets ``shiftwidth``, ``tabstop``, and ``softtabstop`` to 4 on startup. This behavior can be disabled adding ``let g:python_pep8_setlocal_indent = 0`` to your vimrc.

Copy link
Member

@blueyed blueyed Jul 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about using the value from there?

Copy link
Member

@blueyed blueyed Jul 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(4 being the default then)

Copy link
Contributor

@aldanor aldanor Jul 29, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the point is for working with multiple repos, e.g. TensorFlow uses sw=2

Copy link
Member

@blueyed blueyed Jul 29, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. 0 would still disable it (in case you want to set it yourself), but you could specify 2 here then for example.

@blueyed
Copy link
Member

blueyed commented Jul 29, 2017

Could this be combined with #79 ?

@blueyed
Copy link
Member

blueyed commented Jul 29, 2017

Related: #70

Maybe we should just remove all 3 of them?
It is not the job of an indent plugin to do this, but rather of a ftplugin.

blueyed added a commit that referenced this pull request Jul 29, 2017
@blueyed
Do not set expandtab, (soft)tabstop, shiftwidth
f0e3c9e 
It is not the job of an indent plugin to set those.

Closes #70.
Closes #80.
@blueyed blueyed mentioned this pull request Jul 29, 2017
Merged
@blueyed blueyed closed this in #83 Jul 29, 2017
blueyed added a commit that referenced this pull request Jul 29, 2017
@blueyed
Do not set expandtab, (soft)tabstop, shiftwidth (#83)
e0562c8 
It is not the job of an indent plugin to set those.

Closes #70.
Closes #80.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blueyed blueyed blueyed left review comments

+1 more reviewer

@aldanor aldanor aldanor left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aykamko @blueyed @aldanor