Remove Rails dependencies upper bound #2497
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spone
requested review from
BlakeWilliams,
boardfish,
camertron and
reeganviljoen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
To avoid having to push the upper bound on every Rails major release, let's remove it altogether. Our CI suite already tests ViewComponent against Rails main.
What approach did you choose and why?
Just removing the upper bound in the gemspec and updating the gemfile locks.
This is the approach advocated by @byroot in this comment on rails-i81n. Thanks @adrienpoly for pointing it to me.