Skip to content

Commit 4bad99b

Browse files
committed
Fix windows build and testrun
1 parent 89d31ae commit 4bad99b

File tree

2 files changed

+19
-29
lines changed

2 files changed

+19
-29
lines changed

cmake/external/icu.cmake

Lines changed: 18 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -50,21 +50,26 @@ if (UNIX)
5050
set(ICU_INCLUDE_DIR ${ICU_INSTALL}/include)
5151
else()
5252
if(CMAKE_SIZE_OF_VOID_P EQUAL 4)
53-
set(ICU_ARCH lib)
53+
set(ICU_ARCH )
5454
else()
5555
if(${CMAKE_SYSTEM_PROCESSOR} MATCHES arm)
56-
set(ICU_ARCH lib64)
56+
set(ICU_ARCH ARM64)
5757
else()
58-
set(ICU_ARCH libARM64)
58+
set(ICU_ARCH 64)
5959
endif()
6060
endif()
6161
if(CMAKE_BUILD_TYPE STREQUAL "Debug")
62-
set(ICU_I18N_LIBRARY ${ICU_SRC}/src/ICU/${ICU_ARCH}/icuind.lib)
63-
set(ICU_UC_LIBRARY ${ICU_SRC}/src/ICU/${ICU_ARCH}/icuucd.lib)
62+
set(ICU_I18N_LIBRARY ${ICU_SRC}/src/ICU/lib${ICU_ARCH}/icuind.lib)
63+
set(ICU_UC_LIBRARY ${ICU_SRC}/src/ICU/lib${ICU_ARCH}/icuucd.lib)
64+
set(ICU_I18N_DLL ${ICU_SRC}/src/ICU/bin${ICU_ARCH}/icuin72d.dll)
65+
set(ICU_UC_DLL ${ICU_SRC}/src/ICU/bin${ICU_ARCH}/icuuc72d.dll)
6466
else()
65-
set(ICU_I18N_LIBRARY ${ICU_SRC}/src/ICU/${ICU_ARCH}/icuin.lib)
66-
set(ICU_UC_LIBRARY ${ICU_SRC}/src/ICU/${ICU_ARCH}/icuuc.lib)
67+
set(ICU_I18N_LIBRARY ${ICU_SRC}/src/ICU/lib${ICU_ARCH}/icuin.lib)
68+
set(ICU_UC_LIBRARY ${ICU_SRC}/src/ICU/lib${ICU_ARCH}/icuuc.lib)
69+
set(ICU_I18N_DLL ${ICU_SRC}/src/ICU/bin${ICU_ARCH}/icuin72.dll)
70+
set(ICU_UC_DLL ${ICU_SRC}/src/ICU/bin${ICU_ARCH}/icuuc72.dll)
6771
endif()
72+
set(ICU_DATA_DLL ${ICU_SRC}/src/ICU/bin${ICU_ARCH}/icudt72.dll)
6873
set(ICU_INCLUDE_DIR ${ICU_SRC}/src/ICU/include)
6974
endif()
7075

@@ -128,3 +133,9 @@ add_library(ICU::uc STATIC IMPORTED GLOBAL)
128133
set_property(TARGET ICU::uc PROPERTY IMPORTED_LOCATION ${ICU_UC_LIBRARY})
129134
set_property(TARGET ICU::uc PROPERTY INTERFACE_INCLUDE_DIRECTORIES ${ICU_INCLUDE_DIR})
130135
add_dependencies(ICU::uc ICU)
136+
137+
if(WIN32)
138+
add_custom_command(TARGET ICU POST_BUILD COMMAND ${CMAKE_COMMAND} -E copy ${ICU_DATA_DLL} ${CMAKE_BINARY_DIR}/tests)
139+
add_custom_command(TARGET ICU POST_BUILD COMMAND ${CMAKE_COMMAND} -E copy ${ICU_I18N_DLL} ${CMAKE_BINARY_DIR}/tests)
140+
add_custom_command(TARGET ICU POST_BUILD COMMAND ${CMAKE_COMMAND} -E copy ${ICU_UC_DLL} ${CMAKE_BINARY_DIR}/tests)
141+
endif()

tests/CMakeLists.txt

Lines changed: 1 addition & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -47,28 +47,7 @@ function(make_test target)
4747
endfunction()
4848

4949
make_test(distance)
50-
51-
project(test_dump)
52-
53-
add_executable(${PROJECT_NAME}
54-
${PROJECT_NAME}.cpp
55-
)
56-
57-
if(CMAKE_CXX_COMPILER_ID MATCHES "[cC][lL][aA][nN][gG]" AND CMAKE_CXX_COMPILER_VERSION VERSION_LESS 9.0)
58-
set(${PROJECT_NAME}_libs stdc++fs)
59-
endif()
60-
61-
target_link_libraries(${PROJECT_NAME}
62-
PRIVATE
63-
SQLite::Functions
64-
GTest::gtest_main
65-
${${PROJECT_NAME}_libs}
66-
)
67-
68-
gtest_add_tests(${PROJECT_NAME}
69-
SOURCES ${PROJECT_NAME}.cpp
70-
)
71-
50+
make_test(dump)
7251
make_test(transliteration)
7352

7453
include(${CMAKE}/sanitizer_options.cmake)

0 commit comments

Comments
 (0)