Skip to content

Commit 89d31ae

Browse files
committed
Update windows integration
Fix icu architectures build
1 parent d354b7e commit 89d31ae

File tree

3 files changed

+40
-23
lines changed

3 files changed

+40
-23
lines changed

.github/workflows/linux.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ jobs:
1919
ubuntu-20.04-gcc-10,
2020
ubuntu-22.04-gcc-11,
2121
ubuntu-22.04-gcc-12,
22-
ubuntu-20.04-clang-8,
22+
# ubuntu-20.04-clang-8,
2323
ubuntu-20.04-clang-9,
2424
ubuntu-20.04-clang-10,
2525
ubuntu-22.04-clang-11,
@@ -50,10 +50,10 @@ jobs:
5050
compiler: gcc
5151
version: 12
5252

53-
- name: ubuntu-20.04-clang-8
54-
os: ubuntu-20.04
55-
compiler: clang
56-
version: 8
53+
# - name: ubuntu-20.04-clang-8
54+
# os: ubuntu-20.04
55+
# compiler: clang
56+
# version: 8
5757

5858
- name: ubuntu-20.04-clang-9
5959
os: ubuntu-20.04

.github/workflows/macos.yml

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,9 @@ jobs:
1616
matrix:
1717
name: [
1818
macos-12-xcode-13-x86_64,
19-
macos-12-xcode-13-arm64,
20-
macos-12-xcode-14-x86_64,
21-
macos-12-xcode-14-arm64
19+
# macos-12-xcode-13-arm64,
20+
macos-12-xcode-14-x86_64
21+
# macos-12-xcode-14-arm64
2222
]
2323
config: [Debug, Release]
2424
include:
@@ -28,23 +28,23 @@ jobs:
2828
version: "13.4"
2929
cmake: -DCMAKE_OSX_ARCHITECTURES:STRING=x86_64
3030

31-
- name: macos-12-xcode-13-arm64
32-
os: macos-12
33-
compiler: xcode
34-
version: "13.4"
35-
cmake: -DCMAKE_OSX_ARCHITECTURES:STRING=arm64
31+
# - name: macos-12-xcode-13-arm64
32+
# os: macos-12
33+
# compiler: xcode
34+
# version: "13.4"
35+
# cmake: -DCMAKE_OSX_ARCHITECTURES:STRING=arm64
3636

3737
- name: macos-12-xcode-14-x86_64
3838
os: macos-12
3939
compiler: xcode
4040
version: "14.1"
4141
cmake: -DCMAKE_OSX_ARCHITECTURES:STRING=x86_64
4242

43-
- name: macos-12-xcode-14-arm64
44-
os: macos-12
45-
compiler: xcode
46-
version: "14.1"
47-
cmake: -DCMAKE_OSX_ARCHITECTURES:STRING=arm64
43+
# - name: macos-12-xcode-14-arm64
44+
# os: macos-12
45+
# compiler: xcode
46+
# version: "14.1"
47+
# cmake: -DCMAKE_OSX_ARCHITECTURES:STRING=arm64
4848

4949
steps:
5050
- uses: actions/checkout@v3

cmake/external/icu.cmake

Lines changed: 22 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -49,19 +49,36 @@ if (UNIX)
4949
set(ICU_UC_LIBRARY ${ICU_INSTALL}/lib64/libicuuc.a)
5050
set(ICU_INCLUDE_DIR ${ICU_INSTALL}/include)
5151
else()
52+
if(CMAKE_SIZE_OF_VOID_P EQUAL 4)
53+
set(ICU_ARCH lib)
54+
else()
55+
if(${CMAKE_SYSTEM_PROCESSOR} MATCHES arm)
56+
set(ICU_ARCH lib64)
57+
else()
58+
set(ICU_ARCH libARM64)
59+
endif()
60+
endif()
5261
if(CMAKE_BUILD_TYPE STREQUAL "Debug")
53-
set(ICU_I18N_LIBRARY ${ICU_SRC}/src/ICU/lib64/icuind.lib)
54-
set(ICU_UC_LIBRARY ${ICU_SRC}/src/ICU/lib64/icuucd.lib)
62+
set(ICU_I18N_LIBRARY ${ICU_SRC}/src/ICU/${ICU_ARCH}/icuind.lib)
63+
set(ICU_UC_LIBRARY ${ICU_SRC}/src/ICU/${ICU_ARCH}/icuucd.lib)
5564
else()
56-
set(ICU_I18N_LIBRARY ${ICU_SRC}/src/ICU/lib64/icuin.lib)
57-
set(ICU_UC_LIBRARY ${ICU_SRC}/src/ICU/lib64/icuuc.lib)
65+
set(ICU_I18N_LIBRARY ${ICU_SRC}/src/ICU/${ICU_ARCH}/icuin.lib)
66+
set(ICU_UC_LIBRARY ${ICU_SRC}/src/ICU/${ICU_ARCH}/icuuc.lib)
5867
endif()
5968
set(ICU_INCLUDE_DIR ${ICU_SRC}/src/ICU/include)
6069
endif()
6170

6271
if(WIN32)
6372
set(ICU_CONFIGURE_COMMAND echo)
64-
set(ICU_BUILD_COMMAND msbuild ${ICU_SRC}/src/ICU/source/allinone/allinone.sln /p:Configuration=${CMAKE_BUILD_TYPE} /p:Platform=x64 /p:SkipUWP=true /m:${CPU_COUNT})
73+
if(CMAKE_SIZE_OF_VOID_P EQUAL 4)
74+
set(ICU_BUILD_COMMAND msbuild ${ICU_SRC}/src/ICU/source/allinone/allinone.sln /p:Configuration=${CMAKE_BUILD_TYPE} /p:Platform=Win32 /p:SkipUWP=true /m:${CPU_COUNT})
75+
else()
76+
if(${CMAKE_SYSTEM_PROCESSOR} MATCHES arm)
77+
set(ICU_BUILD_COMMAND msbuild ${ICU_SRC}/src/ICU/source/allinone/allinone.sln /p:Configuration=${CMAKE_BUILD_TYPE} /p:Platform=ARM64 /p:SkipUWP=true /m:${CPU_COUNT})
78+
else()
79+
set(ICU_BUILD_COMMAND msbuild ${ICU_SRC}/src/ICU/source/allinone/allinone.sln /p:Configuration=${CMAKE_BUILD_TYPE} /p:Platform=x64 /p:SkipUWP=true /m:${CPU_COUNT})
80+
endif()
81+
endif()
6582
set(ICU_INSTALL_COMMAND echo)
6683
else()
6784
set(ICU_CONFIGURE_COMMAND

0 commit comments

Comments
 (0)