fix crash when autocompleting port map #415
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4f20cbd introduced a regression that causes `completion_item_to_lsp_item` to fail for a formal as insert_text is no longer set now. The new implementation for the conversion function is robust and uses insert_text when available and falls back to the item's label (as an LSP client would)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
4f20cbd introduced a regression that causes
completion_item_to_lsp_itemto fail for a formal as insert_text is no longer set now. The new implementation for the conversion function is robust and uses insert_text when available and falls back to the item's label (as an LSP client would).It would be ideal to have a regression test for this but as the tests are set up now, it seems like a
VHDLServerobject to callcompletion_item_to_lsp_itemon isn't easily available. But as this was the onlyunwrap()in the function, I'm carefully optimistic ;-)