This repository was archived by the owner on Sep 7, 2022. It is now read-only.
Siyao h/1.17/raw touches #201
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhuxingwei
reviewed
Jul 14, 2021
| } | ||
|
|
||
| void Update() { | ||
|
|
Contributor
Author
There was a problem hiding this comment.
I will delete it. This might come from auth reformat code.
| _wrapper.OnPointerLeave(); | ||
| } | ||
|
|
||
| public void OnPointerDown(PointerEventData eventData) { |
Contributor
There was a problem hiding this comment.
we can wrap onPointerDown, onPointerUp, onDrag into one single #if block?
Contributor
Author
There was a problem hiding this comment.
I tried and failed. Since we inherent certain interface, wee need to add these function. Or do we add #if for interface as well?
| var position = _getPointerPosition(new Vector2(param.x, param.y)); | ||
| var pointerId = -1 - param.pointerId; | ||
| switch (param.phase) { | ||
| case 0: |
Contributor
There was a problem hiding this comment.
don't use "magic number", please define some enums and use them instead
Contributor
|
Already included in #226 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.