Skip to content

Conversation

@K-Tone
Copy link
Collaborator

@K-Tone K-Tone commented Nov 6, 2025

Description

Please fill this section with a description what the pull request is trying to address and what changes were made.

Testing status & QA

Please describe the testing already done by you and what testing you request/recommend QA to execute. If you used or created any testing project please link them here too for QA.

Overall Product Risks

Please rate the potential complexity and halo effect from low to high for the reviewers. Note down potential risks to specific Editor branches if any.

  • Complexity:
  • Halo Effect:

Comments to reviewers

Please describe any additional information such as what to focus on, or historical info for the reviewers.

Checklist

Before review:

  • Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • JIRA ticket linked, example (case %%). If it is a private issue, just add the case ID without a link.
    • Jira port for the next release set as "Resolved".
  • Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

After merge:

  • Create forward/backward port if needed. If you are blocked from creating a forward port now please add a task to ISX-1444.

unitALG and others added 30 commits September 19, 2025 15:27
- Content was not modified: this was only to make everything consistent and leverage the extended Markdown feature
# Conflicts:
#	Packages/com.unity.inputsystem/Documentation~/PlayerInput.md
- Applied consistent sizing for most component windows
- Updated the alt text to comply with accessibility standards (not an exhaustive search; just the ones I happened to find)
- Removed some images that were redundant or purely screen shots describing the UI elements that appear in the Editor (future-proofing)
- Also replaced "see <reference>" with "refer to <>" in compliance with style guide guidance
- Similar data but somewhat conflicting information on structure & syntax for InputControl paths
- Merged the information from API to Manual topic on the subject, preferring the API information when it diverged
- Also restructured the table a little to include links to related APIs and manual topics instead of examples
- Removed only the control path information from the InputControlPath class and left a link to the manual topic behind
- Updated the installation instructions to use steps and make it standard compliant
- Also changed the titles to be doc standard compliant (and updated external links pointing there)
- These weren't doc standard compliant and weren't automated (some were missing added sections)
- The sidebar TOCs are already automatically generated by DocFx
- Similar to DOCATT-8578, I merged some of the manual & API documentation for InputControl & PlayerInput classes as part of edits
- Also corrected some links to anchors that didn't exist in Sensors.md, HID.md, and Testing.md
# Conflicts:
#	Packages/com.unity.inputsystem/Documentation~/ActionBindings.md
Removed <para> that seemed accidental causing package validation error.
- Removed GeneratePrecompiledLayout.png which was genuinely not referenced anywhere
- The rest are all still actually being used in the docs, but likely were missed because they were sitting inside an HTML <img> tag instead of the usual Markdown structure, so I switched to use the Markdown structure.
- Switched back to '../api/UnityEngine.InputSystem.Switch.SwitchProControllerHID.html' from 'xref:UnityEngine.InputSystem.Switch.SwitchProControllerHID'
@K-Tone K-Tone changed the title Anthony/docatt FIX: Nothing to see here Nov 6, 2025
@codecov-github-com
Copy link

codecov-github-com bot commented Nov 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

@@             Coverage Diff             @@
##           develop    #2275      +/-   ##
===========================================
+ Coverage    76.70%   76.83%   +0.12%     
===========================================
  Files          465      476      +11     
  Lines        87919    88714     +795     
===========================================
+ Hits         67442    68165     +723     
- Misses       20477    20549      +72     
Flag Coverage Δ
inputsystem_MacOS_2022.3 5.39% <ø> (+0.01%) ⬆️
inputsystem_MacOS_2022.3_project 74.70% <ø> (+0.11%) ⬆️
inputsystem_MacOS_6000.0 5.18% <ø> (-0.01%) ⬇️
inputsystem_MacOS_6000.0_project 76.61% <ø> (+0.10%) ⬆️
inputsystem_MacOS_6000.2 5.18% <ø> (-0.01%) ⬇️
inputsystem_MacOS_6000.2_project 76.60% <ø> (+0.10%) ⬆️
inputsystem_MacOS_6000.3 5.18% <ø> (-0.01%) ⬇️
inputsystem_MacOS_6000.3_project 76.60% <ø> (+0.10%) ⬆️
inputsystem_MacOS_6000.4 5.18% <ø> (-0.01%) ⬇️
inputsystem_MacOS_6000.4_project 76.62% <ø> (+0.11%) ⬆️
inputsystem_MacOS_6000.5 5.18% <ø> (?)
inputsystem_MacOS_6000.5_project 76.62% <ø> (?)
inputsystem_Ubuntu_2022.3 5.39% <ø> (+0.01%) ⬆️
inputsystem_Ubuntu_2022.3_project 74.49% <ø> (+0.10%) ⬆️
inputsystem_Ubuntu_6000.0 5.18% <ø> (-0.01%) ⬇️
inputsystem_Ubuntu_6000.0_project 76.41% <ø> (+0.09%) ⬆️
inputsystem_Ubuntu_6000.2 5.18% <ø> (-0.01%) ⬇️
inputsystem_Ubuntu_6000.2_project 76.41% <ø> (+0.09%) ⬆️
inputsystem_Ubuntu_6000.3 5.18% <ø> (-0.01%) ⬇️
inputsystem_Ubuntu_6000.3_project 76.41% <ø> (+0.09%) ⬆️
inputsystem_Ubuntu_6000.4 5.19% <ø> (-0.01%) ⬇️
inputsystem_Ubuntu_6000.4_project 76.42% <ø> (+0.09%) ⬆️
inputsystem_Ubuntu_6000.5 5.19% <ø> (?)
inputsystem_Ubuntu_6000.5_project 76.42% <ø> (?)
inputsystem_Windows_2022.3 5.39% <ø> (+0.01%) ⬆️
inputsystem_Windows_2022.3_project 74.83% <ø> (+0.10%) ⬆️
inputsystem_Windows_6000.0 5.18% <ø> (-0.01%) ⬇️
inputsystem_Windows_6000.0_project 76.73% <ø> (+0.08%) ⬆️
inputsystem_Windows_6000.2 5.18% <ø> (-0.01%) ⬇️
inputsystem_Windows_6000.2_project 76.73% <ø> (+0.08%) ⬆️
inputsystem_Windows_6000.3 5.18% <ø> (-0.01%) ⬇️
inputsystem_Windows_6000.3_project 76.73% <ø> (+0.08%) ⬆️
inputsystem_Windows_6000.4 5.18% <ø> (-0.01%) ⬇️
inputsystem_Windows_6000.4_project 76.73% <ø> (+0.09%) ⬆️
inputsystem_Windows_6000.5 5.18% <ø> (?)
inputsystem_Windows_6000.5_project 76.74% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ity.inputsystem/InputSystem/Actions/InputAction.cs 92.34% <ø> (ø)
....inputsystem/InputSystem/Actions/InputActionMap.cs 93.22% <ø> (ø)
...nputsystem/InputSystem/Actions/InputActionTrace.cs 79.56% <ø> (ø)
...y.inputsystem/InputSystem/Controls/InputControl.cs 80.98% <ø> (+1.11%) ⬆️
...stem/InputSystem/Controls/InputControlAttribute.cs 100.00% <ø> (ø)
...putsystem/InputSystem/Controls/InputControlPath.cs 87.91% <ø> (ø)
...ity.inputsystem/InputSystem/Controls/KeyControl.cs 73.07% <ø> (ø)
....unity.inputsystem/InputSystem/Devices/Keyboard.cs 95.60% <ø> (ø)
...com.unity.inputsystem/InputSystem/Devices/Mouse.cs 100.00% <ø> (ø)
...om.unity.inputsystem/InputSystem/Devices/Sensor.cs 99.53% <ø> (ø)
... and 6 more

... and 42 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants