Skip to content

Conversation

@TeodorTaushanov
Copy link
Member

@TeodorTaushanov TeodorTaushanov commented Nov 5, 2025

JIRA: BGSOFUIRODOPI-3384

Certain styles for slotted elements in the footer and header are overridden, similar to how it is done in the UI5 dialog.

fixes #8167
fixes #12088

@ui5-webcomponents-bot
Copy link
Collaborator

ui5-webcomponents-bot commented Nov 10, 2025

@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview November 10, 2025 12:02 Inactive
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview November 11, 2025 13:13 Inactive
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview November 14, 2025 14:32 Inactive
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview November 17, 2025 12:48 Inactive
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview November 17, 2025 12:55 Inactive
@TeodorTaushanov TeodorTaushanov changed the title wip(ui5-popover): implement resizable popover feat(ui5-popover): implement resizable popover Nov 19, 2025
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview November 20, 2025 12:54 Inactive
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview November 20, 2025 13:41 Inactive
@TeodorTaushanov TeodorTaushanov requested review from a team and Stoev November 20, 2025 13:46
Copy link
Member

@alexandar-mitsev alexandar-mitsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • during the resize, the arrow constantly flickers. minor issue, but quite visible.
  • sometimes the resize arrow is on the wrong side. This happens if the opener is longer than the popover - e.g. in a very long date picker input, the popover is in leftmost position and the arrow is also in the left bottom arrow. To reproduce set resizable to true on the datepicker input (second input) on test/pages/Popover.html. Same is reproducible in the "Horizontal Align" test section in Popover.html
  • during resize - if you do it quick, the resizing starts to lag. Can stay like that, but if possible to fix, will be better

@TeodorTaushanov
Copy link
Member Author

  • during the resize, the arrow constantly flickers. minor issue, but quite visible.
  • this can be changed with another change. It is going to be a difficult fix.
  • sometimes the resize arrow is on the wrong side. This happens if the opener is longer than the popover - e.g. in a very long date picker input, the popover is in leftmost position and the arrow is also in the left bottom arrow. To reproduce set resizable to true on the datepicker input (second input) on test/pages/Popover.html. Same is reproducible in the "Horizontal Align" test section in Popover.html
  • Fixed.
  • during resize - if you do it quick, the resizing starts to lag. Can stay like that, but if possible to fix, will be better
  • I'm not able to reproduce it.

@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview November 25, 2025 12:26 Inactive
@TeodorTaushanov
Copy link
Member Author

  • during the resize, the arrow constantly flickers. minor issue, but quite visible.
  • It is improved a bit.

@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview November 25, 2025 13:21 Inactive
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview November 25, 2025 13:44 Inactive
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview November 26, 2025 08:13 Inactive
Copy link

@Stoev Stoev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my UA perspective.

Copy link
Member

@alexandar-mitsev alexandar-mitsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. now a popover opened from the right edge of the screen has the resize handle also on the right edge. See screenshot
image
  1. with the latest changes, if you make this sample "Test open popup and hide opener
    " resizable, it can not be resized - the popover hides the moment you click on the resize handle

_width?: string;
_height?: string;

_resizeMouseMoveHandler: (e: MouseEvent) => void;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you may consider moving all those private properties and most of the resize related logic inside a second class, e.g. PopoverResize.ts. It can contain the methods you need, like getResizeHandleClasses, onClose, attachMouseEvents, reset, isResizeHandleClicked and etc.
This will make the Popover.ts easier to read.
Could be separate BLI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support to make ResponsivePopover resizable [Feature Request]: Allow resize option for ResponsivePopover

5 participants