Skip to content

Conversation

@penelopeysm
Copy link
Member

@penelopeysm penelopeysm commented Oct 21, 2025

This is the regular PR for accumulating breaking changes, to be released in the next minor version of DynamicPPL.

Potential 0.39 changes

Largely speaking I (Penny) am fairly happy with the general state of DPPL now. By far the biggest pain point for me, and the only thing I feel like I really want to change in the short term, is ThreadSafeVarInfo. Apart from that, in my opinion, it's now a good time to spend more resources on Turing, samplers, and optimisation.

Suggestions welcome.

@codecov
Copy link

codecov bot commented Oct 21, 2025

Codecov Report

❌ Patch coverage is 76.92308% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.32%. Comparing base (08fffa2) to head (4ca9528).

Files with missing lines Patch % Lines
src/contexts/conditionfix.jl 79.16% 5 Missing ⚠️
src/contexts.jl 50.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1082      +/-   ##
==========================================
- Coverage   81.48%   81.32%   -0.16%     
==========================================
  Files          40       40              
  Lines        3845     3807      -38     
==========================================
- Hits         3133     3096      -37     
+ Misses        712      711       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 31, 2025

Benchmark Report for Commit 4ca9528

Computer Information

Julia Version 1.11.7
Commit f2b3dbda30a (2025-09-08 12:10 UTC)
Build Info:
  Official https://julialang.org/ release
Platform Info:
  OS: Linux (x86_64-linux-gnu)
  CPU: 4 × AMD EPYC 7763 64-Core Processor
  WORD_SIZE: 64
  LLVM: libLLVM-16.0.6 (ORCJIT, znver3)
Threads: 1 default, 0 interactive, 1 GC (on 4 virtual cores)

Benchmark Results

┌───────────────────────┬───────┬─────────────┬───────────────────┬────────┬────────────────┬─────────────────┐
│                 Model │   Dim │  AD Backend │           VarInfo │ Linked │ t(eval)/t(ref) │ t(grad)/t(eval) │
├───────────────────────┼───────┼─────────────┼───────────────────┼────────┼────────────────┼─────────────────┤
│ Simple assume observe │     1 │ forwarddiff │             typed │  false │            6.3 │             1.7 │
│           Smorgasbord │   201 │ forwarddiff │             typed │  false │          710.9 │            44.3 │
│           Smorgasbord │   201 │ forwarddiff │ simple_namedtuple │   true │          398.0 │            60.0 │
│           Smorgasbord │   201 │ forwarddiff │           untyped │   true │          763.5 │            37.8 │
│           Smorgasbord │   201 │ forwarddiff │       simple_dict │   true │         7263.7 │            24.3 │
│           Smorgasbord │   201 │ forwarddiff │      typed_vector │   true │          746.9 │            42.5 │
│           Smorgasbord │   201 │ forwarddiff │    untyped_vector │   true │          774.2 │            38.5 │
│           Smorgasbord │   201 │ reversediff │             typed │   true │          885.1 │            44.8 │
│           Smorgasbord │   201 │    mooncake │             typed │   true │          697.0 │             6.0 │
│           Smorgasbord │   201 │      enzyme │             typed │   true │          871.7 │             4.3 │
│    Loop univariate 1k │  1000 │    mooncake │             typed │   true │         3754.7 │             5.8 │
│       Multivariate 1k │  1000 │    mooncake │             typed │   true │          990.5 │             8.8 │
│   Loop univariate 10k │ 10000 │    mooncake │             typed │   true │        41566.9 │             5.5 │
│      Multivariate 10k │ 10000 │    mooncake │             typed │   true │         8427.0 │            10.0 │
│               Dynamic │    10 │    mooncake │             typed │   true │          114.0 │            12.7 │
│              Submodel │     1 │    mooncake │             typed │   true │            8.7 │             6.2 │
│                   LDA │    12 │ reversediff │             typed │   true │          959.8 │             2.0 │
└───────────────────────┴───────┴─────────────┴───────────────────┴────────┴────────────────┴─────────────────┘

@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2025

DynamicPPL.jl documentation for PR #1082 is available at:
https://TuringLang.github.io/DynamicPPL.jl/previews/PR1082/

* Remove NodeTrait

* Changelog

* Fix exports

* docs

* fix a bug

* Fix doctests

* Fix test

* tweak changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants