Skip to content

bugfix(filesystem): Prevent loading wrong INIZH.big from Data/INI directory to prevent INI CRC mismatch #1879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 30, 2025
+20 −6
Merged

bugfix(filesystem): Prevent loading wrong INIZH.big from Data/INI directory to prevent INI CRC mismatch #1879

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
272ead9
bugfix(big): skip duplicate INIZH.big in Data\INI to prevent CRC mism…
bobtista Nov 18, 2025
95cfca1
build(big): wrap INIZH.big skip in RTS_ZEROHOUR preprocessor guard
bobtista Nov 25, 2025
6deccd7
refactor(big): use endsWithNoCase for INIZH.big path matching
bobtista Nov 25, 2025
2426e0b
refactor(big): use arrow operator and @bugfix tag for INIZH.big skip
bobtista Nov 29, 2025
85ae7f4
refactor(big): remove DeleteFile hack and move comment to skip location
bobtista Nov 29, 2025
c25c377
preserve original case
bobtista Nov 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions Core/GameEngineDevice/Source/StdDevice/Common/StdBIGFileSystem.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,6 +215,16 @@ Bool StdBIGFileSystem::loadBigFilesFromDirectory(AsciiString dir, AsciiString fi
Bool actuallyAdded = FALSE;
FilenameListIter it = filenameList.begin();
while (it != filenameList.end()) {
#if RTS_ZEROHOUR
// TheSuperHackers @bugfix bobtista 18/11/2025 Skip duplicate INIZH.big in Data\INI to prevent CRC mismatches.
// English, Chinese, and Korean SKUs shipped with two INIZH.big files (one in Run directory, one in Run\Data\INI).
// The DeleteFile cleanup doesn't work on EA App/Origin installs because the folder is not writable, so we skip loading it instead.
if (it->endsWithNoCase("Data\\INI\\INIZH.big") || it->endsWithNoCase("Data/INI/INIZH.big")) {
it++;
continue;
}
#endif

ArchiveFile *archiveFile = openArchiveFile((*it).str());

if (archiveFile != NULL) {
Expand Down
10 changes: 10 additions & 0 deletions Core/GameEngineDevice/Source/Win32Device/Common/Win32BIGFileSystem.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,6 +216,16 @@ Bool Win32BIGFileSystem::loadBigFilesFromDirectory(AsciiString dir, AsciiString
Bool actuallyAdded = FALSE;
FilenameListIter it = filenameList.begin();
while (it != filenameList.end()) {
#if RTS_ZEROHOUR
// TheSuperHackers @bugfix bobtista 18/11/2025 Skip duplicate INIZH.big in Data\INI to prevent CRC mismatches.
// English, Chinese, and Korean SKUs shipped with two INIZH.big files (one in Run directory, one in Run\Data\INI).
// The DeleteFile cleanup doesn't work on EA App/Origin installs because the folder is not writable, so we skip loading it instead.
if (it->endsWithNoCase("Data\\INI\\INIZH.big") || it->endsWithNoCase("Data/INI/INIZH.big")) {
it++;
continue;
}
#endif

ArchiveFile *archiveFile = openArchiveFile((*it).str());

if (archiveFile != NULL) {
Expand Down
6 changes: 0 additions & 6 deletions GeneralsMD/Code/GameEngine/Source/Common/GameEngine.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -395,12 +395,6 @@ void GameEngine::init()
// Create the low-level file system interface
TheFileSystem = createFileSystem();

//Kris: Patch 1.01 - November 17, 2003
//I was unable to resolve the RTPatch method of deleting a shipped file. English, Chinese, and Korean
//SKU's shipped with two INIZH.big files. One properly in the Run directory and the other in Run\INI\Data.
//We need to toast the latter in order for the game to patch properly.
DeleteFile( "Data\\INI\\INIZH.big" );

// not part of the subsystem list, because it should normally never be reset!
TheNameKeyGenerator = MSGNEW("GameEngineSubsystem") NameKeyGenerator;
TheNameKeyGenerator->init();
Expand Down
Loading