Fix lobby game sorting to properly sort CRC mismatches to bottom #1845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft

bobtista wants to merge 1 commit into TheSuperHackers:main from bobtista:bobtista/fix-game-lobby-sort-bug

bobtista commented Nov 13, 2025

Fixes Bugged sorting in GameSortStruct::operator() #967 Bugged sorting in GameSortStruct::operator()

Addressed had three issues:

Copy-paste error: g2Good was checking g1 instead of g2
Confusing variable names: g1Good/g2Good were true when CRCs were bad, not good
Wrong return value: returned g1Good instead of g2Good, sorting mismatches to top instead of bottom


          Fix lobby game sorting to properly sort CRC mismatches to bottom

29406c8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet