Added Splay Tree Implementation in Python with Type Hints and Example (Fixes #13844) #13883
Conversation
for more information, see https://pre-commit.ci
algorithms-keeper
bot
added
documentation
![algorithms-keeper[bot]](https://avatars.githubusercontent.com/in/235834?s=60&v=4){kind=small}
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
|
|
||
| # --- Basic Rotation Operations --- | ||
|
|
||
| def _rotate_left(self, x: Node) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/splay_tree.py, please provide doctest for the function _rotate_left
Please provide descriptive name for the parameter: x
| y.left = x | ||
| x.parent = y | ||
|
|
||
| def _rotate_right(self, x: Node) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/splay_tree.py, please provide doctest for the function _rotate_right
Please provide descriptive name for the parameter: x
|
|
||
| # --- Core Splay Operation --- | ||
|
|
||
| def _splay(self, x: Node) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/splay_tree.py, please provide doctest for the function _splay
Please provide descriptive name for the parameter: x
|
|
||
| # --- Search Method (Uses splay) --- | ||
|
|
||
| def search(self, key: int) -> bool: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/splay_tree.py, please provide doctest for the function search
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
|
|
||
| # --- Basic Rotation Operations --- | ||
|
|
||
| def _rotate_left(self, x: Node) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/splay_tree.py, please provide doctest for the function _rotate_left
Please provide descriptive name for the parameter: x
| y.left = x | ||
| x.parent = y | ||
|
|
||
| def _rotate_right(self, x: Node) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/splay_tree.py, please provide doctest for the function _rotate_right
Please provide descriptive name for the parameter: x
|
|
||
| # --- Core Splay Operation --- | ||
|
|
||
| def _splay(self, x: Node) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/splay_tree.py, please provide doctest for the function _splay
Please provide descriptive name for the parameter: x
|
|
||
| # --- Search Method (Uses splay) --- | ||
|
|
||
| def search(self, key: int) -> bool: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/splay_tree.py, please provide doctest for the function search
yeshuawm999
force-pushed
the
splaytree-v4
branch
from
8cf3b82 to
23eeffe
Compare
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
|
|
||
| # --- Basic Rotation Operations --- | ||
|
|
||
| def _rotate_left(self, x: Node) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/splay_tree.py, please provide doctest for the function _rotate_left
Please provide descriptive name for the parameter: x
| y.left = x | ||
| x.parent = y | ||
|
|
||
| def _rotate_right(self, x: Node) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/splay_tree.py, please provide doctest for the function _rotate_right
Please provide descriptive name for the parameter: x
|
|
||
| # --- Core Splay Operation --- | ||
|
|
||
| def _splay(self, x: Node) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/splay_tree.py, please provide doctest for the function _splay
Please provide descriptive name for the parameter: x
|
|
||
| # --- Search Method --- | ||
|
|
||
| def search(self, key: int) -> bool: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/splay_tree.py, please provide doctest for the function search
yeshuawm999
force-pushed
the
splaytree-v4
branch
from
df20d0b to
23eeffe
Compare
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
|
|
||
| # --- Basic Rotation Operations --- | ||
|
|
||
| def _rotate_left(self, x: Node) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/splay_tree.py, please provide doctest for the function _rotate_left
Please provide descriptive name for the parameter: x
| y.left = x | ||
| x.parent = y | ||
|
|
||
| def _rotate_right(self, x: Node) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/splay_tree.py, please provide doctest for the function _rotate_right
Please provide descriptive name for the parameter: x
|
|
||
| # --- Core Splay Operation --- | ||
|
|
||
| def _splay(self, x: Node) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/splay_tree.py, please provide doctest for the function _splay
Please provide descriptive name for the parameter: x
|
|
||
| # --- Search Method --- | ||
|
|
||
| def search(self, key: int) -> bool: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/splay_tree.py, please provide doctest for the function search
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
|
|
||
| # --- Basic Rotation Operations --- | ||
|
|
||
| def _rotate_left(self, x: Node) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/splay_tree.py, please provide doctest for the function _rotate_left
Please provide descriptive name for the parameter: x
| y.left = x | ||
| x.parent = y | ||
|
|
||
| def _rotate_right(self, x: Node) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/splay_tree.py, please provide doctest for the function _rotate_right
Please provide descriptive name for the parameter: x
|
|
||
| # --- Core Splay Operation --- | ||
|
|
||
| def _splay(self, x: Node) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/splay_tree.py, please provide doctest for the function _splay
Please provide descriptive name for the parameter: x
|
|
||
| # --- Search Method --- | ||
|
|
||
| def search(self, key: int) -> bool: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/splay_tree.py, please provide doctest for the function search
yeshuawm999
force-pushed
the
splaytree-v4
branch
from
221e04a to
d41a6ea
Compare
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
|
|
||
| # --- Basic Rotation Operations --- | ||
|
|
||
| def _rotate_left(self, x: Node) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/splay_tree.py, please provide doctest for the function _rotate_left
Please provide descriptive name for the parameter: x
| y.left = x | ||
| x.parent = y | ||
|
|
||
| def _rotate_right(self, x: Node) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/splay_tree.py, please provide doctest for the function _rotate_right
Please provide descriptive name for the parameter: x
|
|
||
| # --- Core Splay Operation --- | ||
|
|
||
| def _splay(self, x: Node) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/splay_tree.py, please provide doctest for the function _splay
Please provide descriptive name for the parameter: x
|
|
||
| # --- Search Method --- | ||
|
|
||
| def search(self, key: int) -> bool: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/splay_tree.py, please provide doctest for the function search
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
|
|
||
| # --- Basic Rotation Operations --- | ||
|
|
||
| def _rotate_left(self, x: Node) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/splay_tree.py, please provide doctest for the function _rotate_left
Please provide descriptive name for the parameter: x
| y.left = x | ||
| x.parent = y | ||
|
|
||
| def _rotate_right(self, x: Node) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/splay_tree.py, please provide doctest for the function _rotate_right
Please provide descriptive name for the parameter: x
|
|
||
| # --- Core Splay Operation --- | ||
|
|
||
| def _splay(self, x: Node) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/splay_tree.py, please provide doctest for the function _splay
Please provide descriptive name for the parameter: x
|
|
||
| # --- Search Method --- | ||
|
|
||
| def search(self, key: int) -> bool: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/splay_tree.py, please provide doctest for the function search
1 participant
Describe your change:
Added a new algorithm implementation: Splay Tree under
data_structures/binary_tree/splay_tree.py.A Splay Tree is a self-adjusting binary search tree that moves recently accessed
elements closer to the root using rotations (splaying).
This improves average access time for frequently used elements.
The implementation includes:
NodeandSplayTreeclasses._rotate_left,_rotate_right)._splayoperation (Zig, Zig-Zig, Zig-Zag cases).search()method that splays the found node to the root.pre-commitandrufflint checks.Fixes #13844
Checklist:
data_structures/binary_tree/.splay_tree.py).Example Output:
Before search: 10
Found: True
After splay, new root: 5
Complexity Analysis
Reference
📘 Wikipedia - Splay Tree