Fix: Out-of-bounds issue in counting_sort_string.cpp (#3055) #3056
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fixed an out-of-bounds access issue in
sorting/counting_sort_string.cppby pre-allocating the output string with the correct size.The previous implementation initialized an empty string and wrote to specific indices, causing undefined behavior and potential crashes.
Now, the
outputstring is initialized asstring output(n, ' ');to ensure safe memory access and correct sorting behavior.Checklist
Notes
This PR addresses issue #3055 and ensures
countSortruns safely without segmentation faults or memory corruption.