Skip to content

Conversation

@theweekday-z
Copy link

@theweekday-z theweekday-z commented Jan 21, 2019

Hopefully I fixed all the deprecation errors, made things more efficient, and just overall improved the code. I see many people straight copying code from tsc so this might reduce the amount of people rushing to servers asking for help on a deprecation warning. While also trying to keep the main basis and keep it simple.

Hopefully I fixed all the deprecation errors, made things more efficient, and just overall improved the code.
const rMember = message.guild.member(message.mentions.users.first()) || message.guild.members.get(args[0]);
if (!rMember) return errors.cantfindUser(message.channel);
let role = args.join(" ").slice(22);
const role = args.join(" ").slice(22);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't use .slice(22):

Copy link
Author

@theweekday-z theweekday-z Jan 22, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Figured i'd forget some issues already in the code. I'll triple check later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants