Skip to content

fix: type issue when void or undefined is returned from query function #3541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 8, 2022
Merged

fix: type issue when void or undefined is returned from query function #3541

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
32f11ad
fix(types): fix handling of promise return type in QueryFunctionData
yss14 Apr 21, 2022
f421cc9
fix(QueryFunction): return type restrict void and avoid union type di…
yss14 Apr 21, 2022
59d6fd5
fix(QueryClient): make setQueryDefaults compatible with adjusted Quer…
yss14 Apr 21, 2022
523a7c3
fix(useQueries): correct type inferrence in GetResults with new Query…
yss14 Apr 21, 2022
7fbf570
fix(tests): adjust all test cases which use any or never as query fun…
yss14 Apr 21, 2022
3481b40
fix(tests): change incorrect query function return types of query tes…
yss14 Apr 21, 2022
ca70f08
feature(useQuery): add test cases covering void and Promise<void> ret…
yss14 Apr 21, 2022
201cae1
feature(useQueries): reject void or undefined as query function retur…
yss14 Apr 22, 2022
b9168c2
feature(useQueries): add test cases for invalid query function return…
yss14 Apr 22, 2022
05e26ae
Merge branch 'beta' of https://github.com/tannerlinsley/react-query i…
yss14 May 4, 2022
6984adc
fix tsc error after rebasing lastest beta branch
yss14 May 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/core/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,13 @@ import type { MutationCache } from './mutationCache'
import { Logger } from './logger'

export type QueryKey = readonly unknown[]
export type QueryFunctionData<T> = T extends undefined ? never : T
export type QueryFunctionData<TReturn> = TReturn extends Promise<
infer TPromiseReturn
>
? Promise<QueryFunctionData<TPromiseReturn>>
: TReturn extends undefined
? never
: TReturn

export type QueryFunction<
T = unknown,
Expand Down