Skip to content

Conversation

@gthay
Copy link

@gthay gthay commented Nov 3, 2025

Summary

  • Fix README templates to use correct 'dev' script instead of non-existent 'start' script
  • Fixes issue where generated projects fail with "Script not found 'start'" error

Files Changed

  • frameworks/react-cra/project/base/README.md.ejs
  • frameworks/solid/project/base/README.md.ejs

Changes

Changed getPackageManagerRunScript('start') to getPackageManagerRunScript('dev') in both template files to match the actual script defined in package.json.

gthay added 2 commits November 3, 2025 20:23
Update React CRA template to use 'dev' script instead of non-existent 'start' script
Update React CRA template to use 'dev' script instead of non-existent 'start' script
@gthay
Copy link
Author

gthay commented Nov 4, 2025

This is the fix for the following ticket of mine.
TanStack/router#5743
I've marked it as closed, as it's in the wrong repo and here is the fix in this pull request.

@bhouston
Copy link

bhouston commented Nov 7, 2025

Yes, that is a good fix. I lost a bunch of time on this issue yesterday. It actually fixes most of this issue (except for the out of date TanStack deployment on node.js docs):

#228

@fanhefeng
Copy link

Just change getPackageManagerRunScript param? I think there is something wrong with the scripts merge.
My .cta.json file includes

"framework": "react-cra",
"chosenAddOns": [
  "start",
  "nitro"
]

Is the framework to be true? export type Framework = 'solid' | 'react' in packages/cta-engine/src/types.ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants