-
-
Notifications
You must be signed in to change notification settings - Fork 419
refactor: file attributes #1190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
TrigamDev
wants to merge
21
commits into
TagStudioDev:main
Choose a base branch
from
TrigamDev:refactor/file-attributes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refactors and reworks how file attributes (file name, file timestamps) and file properties (file size, duration, etc) are handled.
Previously, file properties would be stored as a
FileAttributeDatainstance that gets filled instantly as a file is loaded, operating under the assumption that all data would be present, and then writing it all to a single label.File properties are now stored as a
dictofFilePropertyTypes andFilePropertyWidgets that get updated by callbacks as file data is loaded. Instead of the formatting taking place in a single, very messy method, the responsibility for formatting falls on the respectiveFilePropertyWidget, keeping everything cleanly separated.FileAttributeshas also been split into a model, view, and controller in accordance with #950.Similarly to #1186, relevant files have been sorted into sub directories under the top level
views,models, andcontrollersdirectories (andmixed, cause also doing in MVC split onmedia_player.pyis way out of scope for this PR). This is again something that can be reverted if this is an unwanted change.Closes
Tasks Completed