Skip to content

Fix to parsing of unimplemented meta events #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 13, 2025
Merged

Fix to parsing of unimplemented meta events #13

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e914823
Update midi-converter.js
sune-sje Jun 13, 2025
0481ef9
Mark change in midi-converter.js as patch
WWRS Jun 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions lib/midi-converter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,8 @@
// if no customInterpretr is provided, or returned
// false (=apply default), perform default action
if(this.customInterpreter === null || MIDI.track[t-1].event[e-1].data === false){
file.readInt(metaEventLength);
// PATCH: https://github.com/colxi/midi-parser-js/pull/20
// file.readInt(metaEventLength);
MIDI.track[t-1].event[e-1].data = file.readInt(metaEventLength);
if (this.debug) console.info('Unimplemented 0xFF meta event! data block readed as Integer');
}
Expand Down Expand Up @@ -353,4 +354,4 @@



})();
})();