Refactor equality check in MDS_Format.MountBlobs
#4228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
I sadly can't test this, but I find it highly likely that both this and the original code fail horribly in case a duplicate is found. That said, I looked at how this dictionary is used and don't even see how that makes any sense and works, so... |
YoshiRulz
force-pushed
the
mountblobs-fix
branch
from
e5e56a4 to
7893a1b
Compare
YoshiRulz
force-pushed
the
mountblobs-fix
branch
from
7893a1b to
a3d3e96
Compare
YoshiRulz
added
Core: Octoshock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This goes back to the initial implementation 6d87be1. @Asnivor Can you say whether this matches the original intent? Or just whether it still functions correctly? That's probably more important.
(Throwback to my comment 6 years ago in 1d5a097.)