Skip to content

Conversation

@caesarakalaeii
Copy link

This PR allows connection to non local hosts and enables ipv6 handling.

@ImDevinC
Copy link

It's still a bit strange that validate_ip calls validate_dns, but I think this is fine as is and won't cause confusion.
What linter did you use on this? I think it would be better to do a single PR that has nothing but linter changes, instead of bundling in here, especially since there's no defined linter for this project so that's more of a personal preference

@caesarakalaeii
Copy link
Author

I just used black in the default config, but yeah i can revert that 👍

This reverts commit bb988f5.
@caesarakalaeii
Copy link
Author

and regarding the dns call, that was just the easiest fix, if you want i can change it to if not (self.validate_ip(host) or self.validate_dns(host)): but unsure if that is any better

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants