Skip to content

fix: fix IP validation for allowing only IPv4 Addresses #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: fix IP validation for allowing only IPv4 Addresses #21

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6b80394
fix: fix IP validation for allowing only IPv4 Addresses
Gamesiati Mar 26, 2025
9e3faf1
fix: fix IPv4 addresses always returning true
Gamesiati Mar 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions backend/OBSController.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,8 @@ def validate_ip(self, host: str):
# previous implementations. Again, probably the wrong thing
# long-term, but implementing this way to mitigate risk while we're
# in a bad-push state.
if not addr.version == ipaddress.IPv4Address.version:
if addr.version == 6:
raise ValueError()
return True
except ValueError:
return False

Expand Down