-
Notifications
You must be signed in to change notification settings - Fork 139
Fix notification permission handling and add debugging features #168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
- Add permission checks before enabling notifications - Request browser notification permissions when needed - Add test notification buttons for troubleshooting - Fix notification interval logic to trigger only once per threshold - Improve logging throughout notification system - Make notifications more visible with requireInteraction flag 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
|
too many unnecessary changes and even author is aware of it :( It's even worse, as it looks like author doesn't understand what he was doing here, but conciusly decided to waste others time with this PR, misleading references to not related issue and few other opened issues on the notification topic that he mentioned elsewhere but didn't reference here. very disappointing and IMO code like this should never be merged! At the end it's your call @Stigmatoz |
Your comment adds zero value and should never be added. Please don't comment on things that "conciusly" wastes peoples time. No one needs a regurgitation and my comments were clear about the code being superfluous. The intent is for the author to see what area is broken and fix it, as it's been broken in many versions. Maybe instead of wasting people's time you too can submit some code that fixes something? Thanks. |
Conciously = being aware that:
There was not enough care to describe the what's actually the issue, on which browser, version, despite maintainer previously commenting that notifications are fixed. Last but not least, the only argument for merge is currently "it's vibe coded and I needed it". I understand you are trying to scratch your own itch, and you have good intentions, but my opinion is that this is not the way. |
I was pointing out you misspelled the word.... Look dude, if you have time to misunderstand this much about a PR request you have the time to do something productive. I'm not responding to you anymore, as clearly you have some form of disability and won't understand. Go do something useful bud. |
|
Insulting as argument approach is certanly not making this PR better |
Hello. I prompted with Claude Code a fix for notifications.
I over-prompted this and didn't clean it up. I misunderstood the notification system at first as it's not explained. I thought there would be an inner browser popup somewhere, but in reality (at least for Windows) it is in the notification center.
There's a lot of fluff in here and a lot needs to be trimmed like console commands and not everything may be necessary. But I did test (on Windows) and found that it worked well for daily summaries, one-site reminders, etc.
EDIT: This should address issue #167