Skip to content

Conversation

@Danc2050
Copy link

@Danc2050 Danc2050 commented Oct 12, 2025

Hello. I prompted with Claude Code a fix for notifications.

I over-prompted this and didn't clean it up. I misunderstood the notification system at first as it's not explained. I thought there would be an inner browser popup somewhere, but in reality (at least for Windows) it is in the notification center.

There's a lot of fluff in here and a lot needs to be trimmed like console commands and not everything may be necessary. But I did test (on Windows) and found that it worked well for daily summaries, one-site reminders, etc.

EDIT: This should address issue #167

- Add permission checks before enabling notifications
- Request browser notification permissions when needed
- Add test notification buttons for troubleshooting
- Fix notification interval logic to trigger only once per threshold
- Improve logging throughout notification system
- Make notifications more visible with requireInteraction flag

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@ewoks
Copy link

ewoks commented Oct 12, 2025

too many unnecessary changes and even author is aware of it :( It's even worse, as it looks like author doesn't understand what he was doing here, but conciusly decided to waste others time with this PR, misleading references to not related issue and few other opened issues on the notification topic that he mentioned elsewhere but didn't reference here.

very disappointing and IMO code like this should never be merged! At the end it's your call @Stigmatoz

@Danc2050
Copy link
Author

too many unnecessary changes and even author is aware of it :( It's even worse, as it looks like author doesn't understand what he was doing here, but conciusly decided to waste others time with this PR, misleading references to not related issue and few other opened issues on the notification topic that he mentioned elsewhere but didn't reference here.

very disappointing and IMO code like this should never be merged! At the end it's your call @Stigmatoz

Your comment adds zero value and should never be added. Please don't comment on things that "conciusly" wastes peoples time. No one needs a regurgitation and my comments were clear about the code being superfluous. The intent is for the author to see what area is broken and fix it, as it's been broken in many versions. Maybe instead of wasting people's time you too can submit some code that fixes something? Thanks.

@ewoks
Copy link

ewoks commented Oct 12, 2025

Your comment adds zero value and should never be added.
I respectfully disagree. It adds significantly more value as it warns people on time waste to review unncesarry code that solves vaguely described something about notifications, and reduces maintanability.

Conciously = being aware that:

  • this code is low quality ("I didn't clean it up .... There's a lot of fluff in here and a lot needs to be trimmed ... not everything may be necessary.") ,
  • there are other issues on the same topic (although 69 linked above has nothing to do with some notification issue)

There was not enough care to describe the what's actually the issue, on which browser, version, despite maintainer previously commenting that notifications are fixed.

Last but not least, the only argument for merge is currently "it's vibe coded and I needed it".
The quality of submitted code is imo not satisfactory - it brings in noise, adds unnecessary complexity and reduces maintainability.

I understand you are trying to scratch your own itch, and you have good intentions, but my opinion is that this is not the way.
At the end, if @Stigmatoz understands why this is necessary or what doesn't work, he will decide what to do with it.
In the meantime, if you are happy and it works on your machine, keep using it like that, until the decision

@Danc2050
Copy link
Author

Your comment adds zero value and should never be added.
I respectfully disagree. It adds significantly more value as it warns people on time waste to review unncesarry code that solves vaguely described something about notifications, and reduces maintanability.

Conciously = being aware that:

  • this code is low quality ("I didn't clean it up .... There's a lot of fluff in here and a lot needs to be trimmed ... not everything may be necessary.") ,
  • there are other issues on the same topic (although 69 linked above has nothing to do with some notification issue)

There was not enough care to describe the what's actually the issue, on which browser, version, despite maintainer previously commenting that notifications are fixed.

Last but not least, the only argument for merge is currently "it's vibe coded and I needed it".
The quality of submitted code is imo not satisfactory - it brings in noise, adds unnecessary complexity and reduces maintainability.

I understand you are trying to scratch your own itch, and you have good intentions, but my opinion is that this is not the way.
At the end, if @Stigmatoz understands why this is necessary or what doesn't work, he will decide what to do with it.
In the meantime, if you are happy and it works on your machine, keep using it like that, until the decision

I was pointing out you misspelled the word....

Look dude, if you have time to misunderstand this much about a PR request you have the time to do something productive. I'm not responding to you anymore, as clearly you have some form of disability and won't understand. Go do something useful bud.

@ewoks
Copy link

ewoks commented Oct 13, 2025

Insulting as argument approach is certanly not making this PR better

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants