Fix ruby_abi_version symbol error on macOS #120
Merged
+29
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace static exports.txt with dynamic export file selection based on Ruby version, following grpc's approach. Changes: - Remove exports.txt - Add ext-export.txt (for release versions) - Add ext-export-with-ruby-abi-version.txt (for dev versions) - Update extconf.rb to dynamically select export file based on Ruby version This fixes the 'Undefined symbols: _ruby_abi_version' linker error that occurs when building the gem. Related: - https://bugs.ruby-lang.org/issues/19289 - grpc/grpc#31970 - #117
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When building the gem on macOS, the following linker error occurs:
Solution
This PR replaces the static
exports.txtwith dynamic export file selection based on Ruby version, following grpc's approach.Changes:
exports.txtext-export.txt(for release versions)ext-export-with-ruby-abi-version.txt(for development versions)extconf.rbto dynamically select the appropriate export file based on Ruby versionHow it works:
ext-export.txtwhich only exportsInit_zstdruby. Ruby itself providesruby_abi_version.ext-export-with-ruby-abi-version.txtas needed.Related Issues: