fix(cli): use spawnNode for SEA compatibility #890
Closed
+7
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 6, 2025 09:19
Replace direct spawn('node') calls with spawnNode() utility to properly
handle SEA binary execution. spawnNode() automatically:
- Uses system Node.js when available in SEA context
- Falls back to SEA self-spawning with IPC handshake
- Uses process.execPath in non-SEA context
This ensures local Coana and cdxgen binaries work correctly whether
running from SEA binary or standard Node.js installation.
Changes:
- Import spawnNode from ../spawn/spawn-node.mts
- Replace spawn('node', ...) with spawnNode(...) in spawnCoanaDlx
- Replace spawn('node', ...) with spawnNode(...) in spawnCdxgenDlx
- Remove unused spawn import from @socketsecurity/lib/spawn
Replace spawn('node') with spawnNode() for SEA compatibility when executing
local sfw and python-cli binaries. This ensures proper Node.js resolution
in SEA contexts.
Changes:
- cmd-pip.mts: Use spawnNode for local sfw execution
- python/standalone.mts: Use spawnNode for local python-cli execution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replace direct
spawn('node', ...)calls withspawnNode()utility to ensure proper Node.js execution in SEA (Single Executable Application) contexts.Problem
When running from a SEA binary, spawning
'node'directly may not work correctly. ThespawnNode()utility handles this by:process.execPathin non-SEA contextChanges
Files Updated
src/utils/dlx/spawn.mts- spawnCoanaDlx and spawnCdxgenDlxsrc/commands/pip/cmd-pip.mts- Local sfw executionsrc/utils/python/standalone.mts- Local python-cli executionPattern
Benefits
✅ Proper SEA binary support for local tool execution
✅ Automatic system Node.js detection
✅ Fallback to SEA self-spawning when needed
✅ Works correctly in all contexts (SEA, standard Node.js, local binaries)
Test Plan
Impact
Low risk - Only affects local binary execution paths (when SOCKET_CLI_*_LOCAL_PATH is set). Standard dlx paths are unchanged.