Skip to content

Fix vertical an horizontal scroll of code editor inside component settings #382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hamza-smythos merged 1 commit into from
Dec 9, 2025
Merged

Fix vertical an horizontal scroll of code editor inside component settings #382

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions packages/app/src/builder-ui/ui/dom.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ export function setCodeEditor(
const editor = ace?.edit(div);
editors.push(editor);
editor?.setOptions({
maxLines: Infinity,
maxLines: null,
wrap: wrapLine, // enable horizontal scrolling
showGutter: showLineNumbers,
showLineNumbers,
Expand All @@ -153,7 +153,8 @@ export function setCodeEditor(
hScrollBarAlwaysVisible: false,
});
// Remove fixed height and allow content to determine height
editor.container.style.height = 'auto';
editor.container.style.height = '100%';
editor.container.style.minHeight = '200px';
editor.renderer.setScrollMargin(
scrollMarginTop,
scrollMarginBottom,
Expand Down
36 changes: 0 additions & 36 deletions packages/app/static/css/smyth-builder.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1939,42 +1939,6 @@ ul.agents-list-dlg .btn-delete {
border-right: none !important;
}

/* Hide scrollbars for ace editors in compact/sidebar mode (maxLines: Infinity) */
/* These editors grow to show all content and don't need internal scrolling */
/* Use class-based targeting to only affect sidebar editors, not modal editors */

/* Remove any overflow from the ace editor container itself */
.ace-editor-sidebar {
overflow: visible !important;
}

.ace-editor-sidebar .ace_scrollbar {
display: none !important;
opacity: 0 !important;
visibility: hidden !important;
width: 0 !important;
height: 0 !important;
}

.ace-editor-sidebar .ace_scrollbar-v,
.ace-editor-sidebar .ace_scrollbar-h {
display: none !important;
opacity: 0 !important;
visibility: hidden !important;
width: 0 !important;
height: 0 !important;
}

/* Also hide the scrollbar corner */
.ace-editor-sidebar .ace_scrollbar-corner {
display: none !important;
}

/* Ensure no overflow scrolling on the scroller container */
.ace-editor-sidebar .ace_scroller {
overflow: visible !important;
}

/* css for tooltip in ace editor, to show error, warning, info */
.ace_tooltip {
font:
Expand Down