Skip to content

BRS 8 - Full SSR Hard Source and Loadable support #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

BRS 8 - Full SSR Hard Source and Loadable support #85

wants to merge 6 commits into from

Conversation

@olliecurtis
Copy link
Member

@olliecurtis olliecurtis commented Aug 25, 2020

For more context see #77 .

This PR is to align #77 to BRS v8 for testing before further exploration of configurability for our consumers.

@olliecurtis
Copy link
Member Author

olliecurtis commented Aug 25, 2020

The travis build is expected to fail here as the app paths have been changed in the config.js to support SSR at a particular run which for non SSR consumers modifying these paths would mean that they don't get generated properly so would need to look at the impact on that when people use BRS and serve their website

@ajones513
Copy link

ajones513 commented Aug 26, 2020 •
edited
Loading

Diff looks perfect @olliecurtis, nice spot with the CSS /locals package change. Next step as you say is to make the breaking changes opt-in.

@olliecurtis olliecurtis force-pushed the no-jira-custom-full-ssr-hard-source branch from c6892c8 to 9ab25eb Compare September 11, 2020 15:34
olliecurtis
olliecurtis commented Sep 11, 2020
View reviewed changes
packages/react-scripts/scripts/start-ssr.js Outdated
Copy link
Member Author

@olliecurtis olliecurtis Sep 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turns out the params of this function have changed to accept an object of these parameters so will update with the correct expected format for this

See here for example: https://github.com/Skyscanner/backpack-react-scripts/blob/9ab25eb68904847805d4a5681ab7e6a8620f0845/packages/react-scripts/scripts/start.js#L115

@olliecurtis olliecurtis force-pushed the fork branch 2 times, most recently from 50e36ad to 93ba2ab Compare September 15, 2020 17:05
@olliecurtis olliecurtis force-pushed the no-jira-custom-full-ssr-hard-source branch from cadd3b2 to e8169e3 Compare September 15, 2020 17:11
@olliecurtis olliecurtis force-pushed the fork branch 2 times, most recently from 2defef8 to 1904fcb Compare September 16, 2020 08:36
@olliecurtis olliecurtis force-pushed the no-jira-custom-full-ssr-hard-source branch from e8169e3 to 9f75d1e Compare September 17, 2020 10:48
@olliecurtis olliecurtis changed the title [no jira]: Full SSR, Hard Source plugin BRS-8 - [no jira]: Full SSR, Hard Source plugin Sep 23, 2020
@olliecurtis olliecurtis changed the title BRS-8 - [no jira]: Full SSR, Hard Source plugin BRS 8 - [no jira]: Full SSR, Hard Source plugin Sep 23, 2020
@olliecurtis olliecurtis force-pushed the no-jira-custom-full-ssr-hard-source branch from 6ffad9e to af12611 Compare September 24, 2020 13:08
@olliecurtis olliecurtis force-pushed the fork branch 5 times, most recently from 4670103 to 588bc2b Compare October 23, 2020 10:55
@olliecurtis olliecurtis force-pushed the fork branch 9 times, most recently from 222896f to a9e5e80 Compare November 6, 2020 16:21
@olliecurtis olliecurtis force-pushed the fork branch 3 times, most recently from 3342ce3 to 2497e97 Compare November 26, 2020 19:56
@olliecurtis olliecurtis force-pushed the fork branch 5 times, most recently from 1244339 to dad0045 Compare January 6, 2021 13:06
@olliecurtis olliecurtis force-pushed the fork branch 4 times, most recently from 40a7d29 to db95f43 Compare April 1, 2021 14:54
@olliecurtis olliecurtis force-pushed the fork branch 4 times, most recently from 0bd6040 to 73cfa32 Compare May 14, 2021 19:07
@olliecurtis olliecurtis changed the title BRS 8 - [no jira]: Full SSR, Hard Source plugin BRS 8 - Full SSR Hard Source and Loadable support Jun 4, 2021
@olliecurtis olliecurtis changed the base branch from fork to brs-v8 June 14, 2021 17:10
@olliecurtis olliecurtis force-pushed the no-jira-custom-full-ssr-hard-source branch 2 times, most recently from 640ad0d to 2f44efd Compare June 15, 2021 08:36
@olliecurtis olliecurtis force-pushed the no-jira-custom-full-ssr-hard-source branch from 2f44efd to d088ad5 Compare June 15, 2021 08:37
@olliecurtis
Copy link
Member Author

olliecurtis commented Jan 27, 2022

As BRS 9 is the current supported version and BRS 10 is on the way closing this PR for now

@olliecurtis olliecurtis deleted the no-jira-custom-full-ssr-hard-source branch January 27, 2022 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

DONT MERGE I WIP my hair back and forth WIP

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@olliecurtis @ajones513