-
Notifications
You must be signed in to change notification settings - Fork 385
Add REST API deprecation notice to README #752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I have signed the CLA |
sle-c
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for adding this
|
@sle-c I notice the pre-commit check is failing and blocking the merge. I'll create a separate issue to address this. |
|
@sle-c The CI check is failing, but I believe this is due to the CI issue that has already been fixed in the #755. Options I'm considering:
Please advise on the best approach for this project. |
|
Hi @nasudadada , In this case I'll just merge the PR because it's a readme change. Thank you for your contribution. Si |
|
I'm trying to understand the implications of using this library, as the REST API is now deprecated, in favor of the GraphQL API. Is it ok to continue using this library? Will the parts that are built with REST eventually stop working? Is it better to switch to something like gql? |
|
Hi @cjauvin, This is exactly the same concern that was discussed in #751. Please check out the conversation there, especially @ryantang30's comment which includes the official response from Shopify Developer Support. The key points are:
Hope this helps clarify the situation! |
Add REST API deprecation notice to README
WHY are these changes introduced?
Related to #751 #745
According to Shopify's announcement, the REST Admin API will become legacy as of October 1, 2024. This change adds necessary warnings to the README to inform users about the upcoming deprecation and migration requirements.
WHAT is this pull request doing?
Checklist