-
Notifications
You must be signed in to change notification settings - Fork 906
Record as link for Any table for PDF, Notifications and more.. #2432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Record as link for Any table for PDF, Notifications and more.. #2432
Conversation
Corrected minor grammatical errors and formatting in the README.
ravichandra1998g
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @Its-Nmk
The actual script file only contains a function that calls another script.
ReadMe file should only contain the explanation of what code does and it shouldn't contain any script.
Place all the scripts in a different script file.
Closing this for now. Please resubmit/reopen after making the changes.
|
@ravichandra1998g - Please reopen this PR, If there are any changes needs to be done. Please do not simply close the PR. Suggest a changes if needed. Also, I will create separate file for the example usage of how it can be used. |
Implement PDF generation for incident links using RecordToHTML utility.
Removed example usage section for PDF generation from README.
Removed unnecessary line from README.
|
Hello @Its-Nmk You will have an option to reopen the PR from your side as well. I have suggested changes and have asked to reopen the PR after making the changes. |
|
Hi @ravichandra1998g , I have checked this whole page, but I could not find an option to reopen it. I could altogether open a new Pull request but I would like to learn and know how to reopen the PR. |
|
I have checked some of the docs as well from Github docs. |
|
let me reopen it for you. |
|
Thank you @ravichandra1998g . It seems only the person who closed it or having a write access on the repo can be seen the option to reopen the Pull Request. |
|
@ravichandra1998g - Please review changes now, as I have changed the readme file and having separate file for the example use |
ravichandra1998g
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good now
PR Description:
Adding record as a link util which will generate the link dynamically for any servicenow table record and the display text for link can be dynamic with one of the table field.
Pull Request Checklist
Overview
Code Quality
Repository Structure Compliance
Core ServiceNow APIs/Server-Side Components/Client-Side Components/Modern Development/Integration/Specialized Areas/Documentation
Restrictions