Skip to content

Conversation

@Its-Nmk
Copy link
Contributor

@Its-Nmk Its-Nmk commented Oct 23, 2025

PR Description:

Adding record as a link util which will generate the link dynamically for any servicenow table record and the display text for link can be dynamic with one of the table field.

Pull Request Checklist

Overview

  • Put an x inside of the square brackets to check each item.
  • I have read and understood the CONTRIBUTING.md guidelines
  • My pull request has a descriptive title that accurately reflects the changes and the description has been filled in above.
  • I've included only files relevant to the changes described in the PR title and description
  • I've created a new branch in my forked repository for this contribution

Code Quality

  • My code is relevant to ServiceNow developers
  • My code snippets expand meaningfully on official ServiceNow documentation (if applicable)
  • I've disclosed use of ES2021 features (if applicable)
  • I've tested my code snippets in a ServiceNow environment (where possible)

Repository Structure Compliance

  • I've placed my code snippet(s) in one of the required top-level categories:
    • Core ServiceNow APIs/
    • Server-Side Components/
    • Client-Side Components/
    • Modern Development/
    • Integration/
    • Specialized Areas/
  • I've used appropriate sub-categories within the top-level categories
  • Each code snippet has its own folder with a descriptive name

Documentation

  • I've included a README.md file for each code snippet
  • The README.md includes:
    • Description of the code snippet functionality
    • Usage instructions or examples
    • Any prerequisites or dependencies
    • (Optional) Screenshots or diagrams if helpful

Restrictions

  • My PR does not include XML exports of ServiceNow records
  • My PR does not contain sensitive information (passwords, API keys, tokens)
  • My PR does not include changes that fall outside the described scope

@ravichandra1998g ravichandra1998g self-assigned this Oct 23, 2025
Copy link
Contributor

@ravichandra1998g ravichandra1998g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Its-Nmk

The actual script file only contains a function that calls another script.

ReadMe file should only contain the explanation of what code does and it shouldn't contain any script.

Place all the scripts in a different script file.

Closing this for now. Please resubmit/reopen after making the changes.

@Its-Nmk
Copy link
Contributor Author

Its-Nmk commented Oct 23, 2025

@ravichandra1998g - Please reopen this PR, If there are any changes needs to be done. Please do not simply close the PR. Suggest a changes if needed.

Also, I will create separate file for the example usage of how it can be used.

Implement PDF generation for incident links using RecordToHTML utility.
Removed example usage section for PDF generation from README.
Removed unnecessary line from README.
@ravichandra1998g
Copy link
Contributor

ravichandra1998g commented Oct 23, 2025

Hello @Its-Nmk

You will have an option to reopen the PR from your side as well. I have suggested changes and have asked to reopen the PR after making the changes.
Please make the changes and reopen so that it can be reviewed again.

@Its-Nmk
Copy link
Contributor Author

Its-Nmk commented Oct 23, 2025

Hi @ravichandra1998g ,

I have checked this whole page, but I could not find an option to reopen it. I could altogether open a new Pull request but I would like to learn and know how to reopen the PR.

@Its-Nmk
Copy link
Contributor Author

Its-Nmk commented Oct 23, 2025

I have checked some of the docs as well from Github docs.

@ravichandra1998g
Copy link
Contributor

let me reopen it for you.
We had few of the members reopening PRs after making changes.

@Its-Nmk
Copy link
Contributor Author

Its-Nmk commented Oct 23, 2025

Thank you @ravichandra1998g .

It seems only the person who closed it or having a write access on the repo can be seen the option to reopen the Pull Request.

@Its-Nmk
Copy link
Contributor Author

Its-Nmk commented Oct 23, 2025

@ravichandra1998g - Please review changes now, as I have changed the readme file and having separate file for the example use

Copy link
Contributor

@ravichandra1998g ravichandra1998g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good now

@ravichandra1998g ravichandra1998g merged commit 0da4fa8 into ServiceNowDevProgram:main Oct 23, 2025
2 checks passed
@Its-Nmk Its-Nmk deleted the record-as-link branch October 23, 2025 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants