Skip to content

Conversation

@franks883
Copy link
Contributor

PR Description:

Adds a Business Rule on sys_attachment that quarantines risky uploads. It detects blocked extensions or oversized files, creates a quarantine record, copies the file across, deletes the original, and logs a concise audit message.

Includes README, a small utility Script Include, and the rule script.

Pull Request Checklist

Overview

  • Put an x inside of the square brackets to check each item.
  • I have read and understood the CONTRIBUTING.md guidelines
  • My pull request has a descriptive title that accurately reflects the changes and the description has been filled in above.
  • I've included only files relevant to the changes described in the PR title and description
  • I've created a new branch in my forked repository for this contribution

Code Quality

  • My code is relevant to ServiceNow developers
  • My code snippets expand meaningfully on official ServiceNow documentation (if applicable)
  • I've disclosed use of ES2021 features (if applicable)
  • I've tested my code snippets in a ServiceNow environment (where possible)

Repository Structure Compliance

  • I've placed my code snippet(s) in one of the required top-level categories:
    • Core ServiceNow APIs/
    • Server-Side Components/
    • Client-Side Components/
    • Modern Development/
    • Integration/
    • Specialized Areas/
  • I've used appropriate sub-categories within the top-level categories
  • Each code snippet has its own folder with a descriptive name

Documentation

  • I've included a README.md file for each code snippet
  • The README.md includes:
    • Description of the code snippet functionality
    • Usage instructions or examples
    • Any prerequisites or dependencies
    • (Optional) Screenshots or diagrams if helpful

Restrictions

  • My PR does not include XML exports of ServiceNow records
  • My PR does not contain sensitive information (passwords, API keys, tokens)
  • My PR does not include changes that fall outside the described scope

@snamjosh snamjosh self-assigned this Oct 21, 2025
@snamjosh
Copy link
Contributor

Thank you for your contribution. However, it doesn’t comply with our contributing guidelines. As a reminder, the general requirements (as outlined in the CONTRIBUTING.md file) are the following: follow the folder+subfolder+snippetfolder guidelines and include a readme.md file explaining what the code snippet does. Review your contribution against the guidelines and make the necessary adjustments. Closing this for now. Once you make additional changes, feel free to re-open this Pull Request or create a new one.

@snamjosh snamjosh closed this Oct 21, 2025
@franks883
Copy link
Contributor Author

Hi @snamjosh - Thanks for your feedback, I have reviewed your comment but I cant identify where I've gone wrong here - is it my technical solution that doesn't meet the criteria - or is it the structure of the folder?

@snamjosh
Copy link
Contributor

snamjosh commented Oct 21, 2025

In your case, you need to look into existing folder structure https://github.com/ServiceNowDevProgram/code-snippets/tree/main/Server-Side%20Components

e.g please don't add script include file under business rule folder. there are separate folders maintained for each object.

Take a look at below

https://github.com/ServiceNowDevProgram/code-snippets/tree/main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants