Skip to content

Conversation

@Sriharsha19
Copy link
Contributor

Issue Reference:

This pull request addresses the issue I raised in #2299 by implementing the proposed fixes and enhancements.

PR Description:

This PR refactors the incident cancellation UI Action by replacing the existing GlideModal confirmation with a simpler, native JavaScript confirm() dialog. The change improves code readability, reduces complexity, and enhances maintainability while retaining the full functional behavior.

Changes Made:

  • Updated the client script to use confirm() for user confirmation before cancellation.
  • Simplified the server-side script to update the incident state to "Cancelled" with added work notes for traceability.
  • Ensured proper redirection post cancellation for a smooth user experience.
  • Added a button visibility condition so that the Cancel Incident button is only visible when the incident state is New, Inprogress, or On Hold.
  • The button is hidden when the incident state is Resolved or Cancelled to avoid confusion and inappropriate usage.

Benefits:

  • Removes unnecessary modal complexity.
  • Better separation of client-server responsibilities.
  • Easier to understand, maintain, and extend.
  • Aligns with ServiceNow scripting best practices.
  • Improves UI clarity by showing the Cancel button only when appropriate.

Pull Request Checklist

Overview

  • Put an x inside of the square brackets to check each item.
  • I have read and understood the CONTRIBUTING.md guidelines
  • My pull request has a descriptive title that accurately reflects the changes and the description has been filled in above.
  • I've included only files relevant to the changes described in the PR title and description
  • I've created a new branch in my forked repository for this contribution

Code Quality

  • My code is relevant to ServiceNow developers
  • My code snippets expand meaningfully on official ServiceNow documentation (if applicable)
  • I've disclosed use of ES2021 features (if applicable)
  • I've tested my code snippets in a ServiceNow environment (where possible)

Repository Structure Compliance

  • I've placed my code snippet(s) in one of the required top-level categories:
    • Core ServiceNow APIs/
    • Server-Side Components/
    • Client-Side Components/
    • Modern Development/
    • Integration/
    • Specialized Areas/
  • I've used appropriate sub-categories within the top-level categories
  • Each code snippet has its own folder with a descriptive name

Documentation

  • I've included a README.md file for each code snippet
  • The README.md includes:
    • Description of the code snippet functionality
    • Usage instructions or examples
    • Any prerequisites or dependencies
    • (Optional) Screenshots or diagrams if helpful

Restrictions

  • My PR does not include XML exports of ServiceNow records
  • My PR does not contain sensitive information (passwords, API keys, tokens)
  • My PR does not include changes that fall outside the described scope

Visual Proof

  • Configured Cancel Incident button on the incident form:
image
  • When user clicks on Cancel Incident a pop up is displayed asking for user confirmation
image

-When user clicks on ok then the incident is cancelled and work notes is also added for traceability.
image

Button Visibility :

  • Added a button visibility condition so that the Cancel Incident button is only visible when the incident state is New, Inprogress, or On Hold.
  • The button is hidden when the incident state is Resolved or Cancelled to avoid confusion and inappropriate usage.
image

@ravichandra1998g ravichandra1998g self-assigned this Oct 20, 2025
@ravichandra1998g
Copy link
Contributor

Hello @Sriharsha19
You do not need to raise an issue to fix an existing code, you can directly work on it and submit a PR.
Since the original issue is already resolved under different PR, this cannot be merged.

We appreciate the effort you’ve put into this contribution. We’ve labeled it as hacktoberfest-accepted so it still counts toward your Hacktoberfest progress. Thank you for contributing!

@ravichandra1998g ravichandra1998g added the hacktoberfest-accepted The PR is accepted for Hacktoberfest, regardless of being merged or not label Oct 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hacktoberfest-accepted The PR is accepted for Hacktoberfest, regardless of being merged or not

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants