Skip to content

Conversation

@chaitaliKundu
Copy link
Contributor

PR Description:

replace this with your description

Pull Request Checklist

Overview

  • Put an x inside of the square brackets to check each item.
  • I have read and understood the CONTRIBUTING.md guidelines
  • My pull request has a descriptive title that accurately reflects the changes and the description has been filled in above.
  • I've included only files relevant to the changes described in the PR title and description
  • I've created a new branch in my forked repository for this contribution

Code Quality

  • My code is relevant to ServiceNow developers
  • My code snippets expand meaningfully on official ServiceNow documentation (if applicable)
  • I've disclosed use of ES2021 features (if applicable)
  • I've tested my code snippets in a ServiceNow environment (where possible)

Repository Structure Compliance

  • I've placed my code snippet(s) in one of the required top-level categories:
    • Core ServiceNow APIs/
    • Server-Side Components/
    • Client-Side Components/
    • Modern Development/
    • Integration/
    • Specialized Areas/
  • I've used appropriate sub-categories within the top-level categories
  • Each code snippet has its own folder with a descriptive name

Documentation

  • I've included a README.md file for each code snippet
  • The README.md includes:
    • Description of the code snippet functionality
    • Usage instructions or examples
    • Any prerequisites or dependencies
    • (Optional) Screenshots or diagrams if helpful

Restrictions

  • My PR does not include XML exports of ServiceNow records
  • My PR does not contain sensitive information (passwords, API keys, tokens)
  • My PR does not include changes that fall outside the described scope

@chaitaliKundu
Copy link
Contributor Author

@bird-03 could you please check? I have create new PR as PR#2182 closed.

@rohi-v rohi-v self-assigned this Oct 16, 2025
Copy link
Contributor

@rohi-v rohi-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @chaitaliKundu
Please take a look at the review comments.

The code doesn't seem to work, Please validate and update logic accordingly.

@@ -0,0 +1,15 @@
// UI Action - "Redirect to Adobe Sign".
// HR Agent workspace
Trigger Condition - current.hr_service== gs.getproperty("On Boarding HR Service");
Copy link
Contributor

@rohi-v rohi-v Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove specific conditions and mention 'conditions as per requirements'.


g_form.setValue("work_notes","Redirected to Adobe Application"); // Worknotes updated
g_form.addInfoMessage("Redirected to Adobe Application");
var win= top.window.open("https://xyz.eu1.echosign.com/account/homeJS",'_blank'); // Redirect to Adobe Sign page
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for Any URL so making it generic will help users understand.
Mention in readme file how this can be used for other pages.

@rohi-v
Copy link
Contributor

rohi-v commented Oct 17, 2025

Hi @chaitaliKundu
Did you get a chance to look at above comments?

@rohi-v
Copy link
Contributor

rohi-v commented Oct 18, 2025

Hi @chaitaliKundu

Closing this for now. Once you make additional and requested changes, feel free to re-open this Pull Request or create a new one.

@rohi-v rohi-v closed this Oct 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants