Skip to content

Conversation

@Shashank102002
Copy link
Contributor

@Shashank102002 Shashank102002 commented Oct 12, 2025

PR Description:

replace this with your description

Pull Request Checklist

Overview

  • Put an x inside of the square brackets to check each item.
  • I have read and understood the CONTRIBUTING.md guidelines
  • My pull request has a descriptive title that accurately reflects the changes and the description has been filled in above.
  • I've included only files relevant to the changes described in the PR title and description
  • I've created a new branch in my forked repository for this contribution

Code Quality

  • My code is relevant to ServiceNow developers
  • My code snippets expand meaningfully on official ServiceNow documentation (if applicable)
  • I've disclosed use of ES2021 features (if applicable)
  • I've tested my code snippets in a ServiceNow environment (where possible)

Repository Structure Compliance

  • I've placed my code snippet(s) in one of the required top-level categories:
    • Core ServiceNow APIs/
    • Server-Side Components/
    • Client-Side Components/
    • Modern Development/
    • Integration/
    • Specialized Areas/
  • I've used appropriate sub-categories within the top-level categories
  • Each code snippet has its own folder with a descriptive name

Documentation

  • I've included a README.md file for each code snippet
  • The README.md includes:
    • Description of the code snippet functionality
    • Usage instructions or examples
    • Any prerequisites or dependencies
    • (Optional) Screenshots or diagrams if helpful

Restrictions

  • My PR does not include XML exports of ServiceNow records
  • My PR does not contain sensitive information (passwords, API keys, tokens)
  • My PR does not include changes that fall outside the described scope

@kmohit2809 kmohit2809 self-assigned this Oct 12, 2025
@kmohit2809
Copy link
Contributor

Thanks for your contribution @Shashank102002 . The scripts logic looks fine to me, however, instead of directly getting the value, use of getValue() method would be preferable and less error prone as the other way can lead you to same pointer error in object reference. Once you make those changes. I can merge your request.

@Shashank102002
Copy link
Contributor Author

@kmohit2809 , Thanks for the feedback!
Made the changes, Please review.

@kmohit2809
Copy link
Contributor

kmohit2809 commented Oct 12, 2025

I am not able to see your changes. To me the lines are still same like userRecord.sys_id and all other places where you are getting the value for querying.
In line no 9 and 13 you arr directly accessing the value. Kindly make those changes as well

@Shashank102002 Shashank102002 deleted the sj_codesnippet branch October 12, 2025 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants