Skip to content

Conversation

@raghavs046
Copy link
Contributor

@raghavs046 raghavs046 commented Oct 10, 2025

PR Description:

replace this with your description

Pull Request Checklist

Overview

  • Put an x inside of the square brackets to check each item.
  • I have read and understood the CONTRIBUTING.md guidelines
  • My pull request has a descriptive title that accurately reflects the changes and the description has been filled in above.
  • I've included only files relevant to the changes described in the PR title and description
  • I've created a new branch in my forked repository for this contribution

Code Quality

  • My code is relevant to ServiceNow developers
  • My code snippets expand meaningfully on official ServiceNow documentation (if applicable)
  • I've disclosed use of ES2021 features (if applicable)
  • I've tested my code snippets in a ServiceNow environment (where possible)

Repository Structure Compliance

  • I've placed my code snippet(s) in one of the required top-level categories:
    • Core ServiceNow APIs/
    • Server-Side Components/
    • Client-Side Components/
    • Modern Development/
    • Integration/
    • Specialized Areas/
  • I've used appropriate sub-categories within the top-level categories
  • Each code snippet has its own folder with a descriptive name

Documentation

  • I've included a README.md file for each code snippet
  • The README.md includes:
    • Description of the code snippet functionality
    • Usage instructions or examples
    • Any prerequisites or dependencies
    • (Optional) Screenshots or diagrams if helpful

Restrictions

  • My PR does not include XML exports of ServiceNow records
  • My PR does not contain sensitive information (passwords, API keys, tokens)
  • My PR does not include changes that fall outside the described scope

@ivan-betev ivan-betev self-assigned this Oct 10, 2025
@raghavs046 raghavs046 changed the title Replace inactive grp managers Replace inactive group managers Oct 10, 2025
@ivan-betev
Copy link
Contributor

Thank you for your contribution. However, it doesn’t comply with our contributing guidelines.

As a reminder, the general requirements (as outlined in the CONTRIBUTING.md file) are the following: follow the folder+subfolder+snippetfolder guidelines and include a readme.md file explaining what the code snippet does. Review your contribution against the guidelines and make the necessary adjustments.

Please fix it, and I'll approve.

@raghavs046
Copy link
Contributor Author

@ivan-betev Can you please check

@ivan-betev
Copy link
Contributor

@raghavs046 - your parent folder is incorrect, put it one level higher.

@github-actions
Copy link

Thank you for your contribution. However, it doesn't comply with our contributing guidelines.

As a reminder, the general requirements (as outlined in the CONTRIBUTING.md file) are the following: follow the folder+subfolder guidelines and include a README.md file explaining what the code snippet does.

Validation errors:

Folder structure violations found:
 - Move 'Specialized Areas/Fix scripts/Replace Inactive managers with active members' under a valid folder hierarchy (Category/Subcategory/Use-Case/your-file). Files directly inside 'Specialized Areas' or its subcategories are not allowed.

Review your contribution against the guidelines and make the necessary adjustments. Closing this for now. Once you make additional changes, feel free to re-open this Pull Request or create a new one.

@github-actions github-actions bot closed this Oct 10, 2025
@raghavs046
Copy link
Contributor Author

@ivan-betev one level higher is Fix script folder, when I tried adding it there, it closed the pull request mentioning "Folder structure violations found:"

Can you please guide here?

@ivan-betev ivan-betev reopened this Oct 10, 2025
@ivan-betev
Copy link
Contributor

You were committing to the folder directly; you should have specified the file at the end e.g. folder/script.js. I did it for you.

@ivan-betev
Copy link
Contributor

Thank you for your contribution. It looks good to me now.

@ivan-betev ivan-betev merged commit cbc92bc into ServiceNowDevProgram:main Oct 10, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants