Skip to content

Conversation

@Vishnu-rvk
Copy link
Contributor

PR Description:

Whenever new users onboarded BR will automatically create unique mail to the user and update it to user record.

Inputs: User Full Name, Unique User ID (Vishnu Kumar, 10321717)
Output: Unique email id generated and tagged to user record.

Pull Request Checklist

Overview

  • [YES] Put an x inside of the square brackets to check each item.
  • [YES] I have read and understood the CONTRIBUTING.md guidelines
  • [YES] My pull request has a descriptive title that accurately reflects the changes and the description has been filled in above.
  • [YES] I've included only files relevant to the changes described in the PR title and description
  • [YES] I've created a new branch in my forked repository for this contribution

Code Quality

  • [YES] My code is relevant to ServiceNow developers
  • [YES] My code snippets expand meaningfully on official ServiceNow documentation (if applicable)
  • [] I've disclosed use of ES2021 features (if applicable)
  • [YES] I've tested my code snippets in a ServiceNow environment (where possible)

Repository Structure Compliance

  • [YES] I've placed my code snippet(s) in one of the required top-level categories:
    • Core ServiceNow APIs/
    • Server-Side Components/
    • Client-Side Components/
    • Modern Development/
    • Integration/
    • Specialized Areas/
  • [YES] I've used appropriate sub-categories within the top-level categories
  • [YES] Each code snippet has its own folder with a descriptive name

Documentation

  • [YES] I've included a README.md file for each code snippet
  • [YES] The README.md includes:
    • Description of the code snippet functionality
    • Usage instructions or examples
    • Any prerequisites or dependencies
    • (Optional) Screenshots or diagrams if helpful

Restrictions

  • [YES] My PR does not include XML exports of ServiceNow records
  • [YES] My PR does not contain sensitive information (passwords, API keys, tokens)
  • [YES] My PR does not include changes that fall outside the described scope

Whenever new users onboarded BR will automatically create unique mail to the user and update it to user record
File explaining email autogenerate script
@mskoddow mskoddow self-assigned this Oct 10, 2025
Copy link
Contributor

@mskoddow mskoddow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, however there are issues that need to be fixed!

Your Business Rule omits essential context: the target table, trigger type and specific configuration are not specified. The script is error-prone and misleading; for example, it fetches initials in uppercase then converts them to lowercase, an inconsistent and unnecessary transformation.

Please provide a descriptive readme and optimize your script. Then your PR will be approved.

@mskoddow mskoddow self-requested a review October 10, 2025 08:22
@mskoddow
Copy link
Contributor

@Vishnu-rvk
Could you please answer my questions? Otherwise, I will close the PR by the end of the day. Thanks!

@mskoddow
Copy link
Contributor

Due to missing fixes for the requested changes, I’m closing this pull request. You may reopen it or submit a new one once the issues are addressed.

@mskoddow mskoddow closed this Oct 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants