Add incidenthelper snippet #1877
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillemZeiler
requested changes
Oct 6, 2025
Contributor
WillemZeiler
left a comment
WillemZeiler
left a comment
There was a problem hiding this comment.
Thank you for your submission. I have included some comments for you to look at, once these are changed, feel free to resubmit a PR.
| ga.addParam('sysparm_name','getOpenIncidents'); | ||
| ga.getXMLAnswer(function(response){ | ||
| var list = JSON.parse(response || '[]'); | ||
| console.log(list); |
Contributor
There was a problem hiding this comment.
Can you add an example of what the output will look like? This will help others more easily understand what the code does.
| getOpenIncidents: function() { | ||
| var gr = new GlideRecord('incident'); | ||
| gr.addQuery('active', true); | ||
| gr.orderByDesc('sys_created_on'); |
Contributor
There was a problem hiding this comment.
Why are you ordering descending on created on? Add this to your readme or a comment.
| var gr = new GlideRecord('incident'); | ||
| gr.addQuery('active', true); | ||
| gr.orderByDesc('sys_created_on'); | ||
| gr.setLimit(50); |
Contributor
There was a problem hiding this comment.
Why are you limiting to 50? Can you add this to the readme or include a comment?
| var list = []; | ||
| while (gr.next()) { | ||
| list.push({ | ||
| number: gr.getValue('number'), |
Contributor
There was a problem hiding this comment.
Perhaps you can include in the readme that this code now only pushes these attributes, and not the full Incident?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description:
Pull Request Checklist
Overview
Code Quality
Repository Structure Compliance
Core ServiceNow APIs/Server-Side Components/Client-Side Components/Modern Development/Integration/Specialized Areas/Documentation
Restrictions