Skip to content

Conversation

@Jaspalsinghchot
Copy link
Contributor

PR Description:

Pull Request Checklist

Overview

  • I have read and understood the CONTRIBUTING.md guidelines
  • My pull request has a descriptive title that accurately reflects the changes
  • I've included only files relevant to the changes described in the PR title and description
  • I've created a new branch in my forked repository for this contribution

Code Quality

  • My code is relevant to ServiceNow developers
  • My code snippets expand meaningfully on official ServiceNow documentation (if applicable)
  • I've disclosed use of ES2021 features (if applicable)
  • I've tested my code snippets in a ServiceNow environment (where possible)

Repository Structure Compliance

  • I've placed my code snippet(s) in one of the required top-level categories:
    • Core ServiceNow APIs/
    • Server-Side Components/
    • Client-Side Components/
    • Modern Development/
    • Integration/
    • Specialized Areas/
  • I've used appropriate sub-categories within the top-level categories
  • Each code snippet has its own folder with a descriptive name

Documentation

  • I've included a README.md file for each code snippet
  • The README.md includes:
    • Description of the code snippet functionality
    • Usage instructions or examples
    • Any prerequisites or dependencies
    • (Optional) Screenshots or diagrams if helpful

Restrictions

  • My PR does not include XML exports of ServiceNow records
  • My PR does not contain sensitive information (passwords, API keys, tokens)
  • My PR does not include changes that fall outside the described scope

@rohi-v rohi-v self-assigned this Oct 4, 2025
@Jaspalsinghchot Jaspalsinghchot marked this pull request as draft October 4, 2025 08:46
@Jaspalsinghchot Jaspalsinghchot marked this pull request as ready for review October 4, 2025 08:48
@rohi-v
Copy link
Contributor

rohi-v commented Oct 4, 2025

Hi @Jaspalsinghchot

Thanks for your submission.

The code looks good However It appears that this pull request contains more files than described in the title. Please review and update the pull request to either remove the extra/unintended files.

The below path for Attachment doesn't exist, you can create these under background Scripts (Path - Server-Side Components/Background Scripts or under Integration/Attachments)
image

[If applicable: You can create a new branch on your forked repository to avoid accidental inclusions of new commits in the future.]. Closing this for now. Once you make additional changes, feel free to re-open this Pull Request or create a new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants