Skip to content

Conversation

@shivamvish160
Copy link
Contributor

PR Description:

Pull Request Checklist

Overview

  • I have read and understood the CONTRIBUTING.md guidelines
  • My pull request has a descriptive title that accurately reflects the changes
  • I've included only files relevant to the changes described in the PR title and description
  • I've created a new branch in my forked repository for this contribution

Code Quality

  • My code is relevant to ServiceNow developers
  • My code snippets expand meaningfully on official ServiceNow documentation (if applicable)
  • I've disclosed use of ES2021 features (if applicable)
  • I've tested my code snippets in a ServiceNow environment (where possible)

Repository Structure Compliance

  • I've placed my code snippet(s) in one of the required top-level categories:
    • Core ServiceNow APIs/
    • Server-Side Components/
    • Client-Side Components/
    • Modern Development/
    • Integration/
    • Specialized Areas/
  • I've used appropriate sub-categories within the top-level categories
  • Each code snippet has its own folder with a descriptive name

Documentation

  • I've included a README.md file for each code snippet
  • The README.md includes:
    • Description of the code snippet functionality
    • Usage instructions or examples
    • Any prerequisites or dependencies
    • (Optional) Screenshots or diagrams if helpful

Restrictions

  • My PR does not include XML exports of ServiceNow records
  • My PR does not contain sensitive information (passwords, API keys, tokens)
  • My PR does not include changes that fall outside the described scope

@WillemZeiler WillemZeiler self-assigned this Oct 3, 2025
Copy link
Contributor

@WillemZeiler WillemZeiler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your submission. In general I would be careful with script includes that wrap the ootb GlideRecord. The syntax is deviating to what every ServiceNow developer knows, it requires additional code execution, and the default functions are not available in the wrapper (f.e. updating a record).

GlideRecordHelper.prototype = {
initialize: function(tableName) {
if (!tableName) {
throw new Error("Table name is required.");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is your reason to handle the error in this way?


for (var key in queryObj) {
if (queryObj.hasOwnProperty(key)) {
gr.addQuery(key, queryObj[key]);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would expect error handling here as well. If an object value is now empty it will query on empty resulting in unexpected behavior that will be difficult to spot.

},

getRecords: function(queryObj) {
var gr = new GlideRecord(this.tableName);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to go the wrapper route, it would make sense to add additional error handling, security, and input validations to make it more robust.

var records = helper.getRecords({ priority: 1, active: true });

records.forEach(function(record) {
gs.info(record.number);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if, based on the GlideRecord we did, we want to update one or multiple values on the record?

@WillemZeiler
Copy link
Contributor

Thank you for your submission. I have added comments to the code. I would suggest not using wrapper functions like this, but if you want to continue with the code, you can use the comments.
I will close the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants