Skip to content

Conversation

@naveensnow
Copy link
Contributor

@naveensnow naveensnow commented Oct 1, 2025

Pull Request Checklist

Overview

  • I have read and understood the CONTRIBUTING.md guidelines
  • My pull request has a descriptive title that accurately reflects the changes
  • I've included only files relevant to the changes described in the PR title and description
  • I've created a new branch in my forked repository for this contribution

Code Quality

  • My code is relevant to ServiceNow developers
  • My code snippets expand meaningfully on official ServiceNow documentation (if applicable)
  • I've disclosed use of ES2021 features (if applicable)
  • I've tested my code snippets in a ServiceNow environment (where possible)

Repository Structure Compliance

  • I've placed my code snippet(s) in one of the required top-level categories:
    • Core ServiceNow APIs/
    • Server-Side Components/
    • Client-Side Components/
    • Modern Development/
    • Integration/
    • Specialized Areas/
  • I've used appropriate sub-categories within the top-level categories
  • Each code snippet has its own folder with a descriptive name

Documentation

  • I've included a README.md file for each code snippet
  • The README.md includes:
    • Description of the code snippet functionality
    • Usage instructions or examples
    • Any prerequisites or dependencies
    • (Optional) Screenshots or diagrams if helpful

Restrictions

  • My PR does not include XML exports of ServiceNow records
  • My PR does not contain sensitive information (passwords, API keys, tokens)
  • My PR does not include changes that fall outside the described scope

This is the UI action script which is calling UI page on any form which has work notes or comments
removed unwanted variable
@ivan-betev ivan-betev self-assigned this Oct 1, 2025
@ivan-betev
Copy link
Contributor

Thank you for your contribution. You are almost there. :-)

However, the title and description of this Pull Request are too vague and do not provide sufficient context or clarity regarding the changes made.

It has some inconsistencies around its functionality as it returns not only work notes but comments. Actually what pops up first. The code is missing null checks as well, and variable/function naming might confuse and mislead.

Please update the mentioned points, title and description with more detailed and specific information about the modifications, the reason behind them, and their expected impact.

This will help in better understanding and reviewing your contribution effectively. Closing this for now. Once you make additional changes, feel free to re-open this Pull Request or create a new one.

@ivan-betev ivan-betev closed this Oct 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants