Skip to content

Conversation

@anveshmupparaju
Copy link
Contributor

CustomCurrencyUtils

Purpose

CustomCurrencyUtils.js provides utility functions for handling custom currency operations within your application. It facilitates formatting, parsing, and conversion of currency values, supporting both standard and custom currency types. These utilities help ensure consistency and accuracy when displaying or processing monetary values, especially in scenarios involving multiple currencies are enabled.

Usefulness

  • Centralizes currency-related logic, reducing code duplication.
  • Simplifies integration of custom currencies by abstracting formatting and conversion details.
  • Enhances maintainability by providing a single location for currency utilities.
  • Improves user experience by ensuring currency values are presented clearly and consistently.

Usage

  1. Get Currency value in reference currency:
    var ref_currency = new CustomCurrencyUtils().getReferenceValue('<sys_id>', '<your_field>');

@am-shakeel am-shakeel assigned am-shakeel and unassigned am-shakeel Oct 1, 2025
@mskoddow mskoddow self-assigned this Oct 1, 2025
@mskoddow
Copy link
Contributor

mskoddow commented Oct 1, 2025

Thank you for your contribution. However, there are several issues which needs to be fixed first:

  • The documentation states "provides utility functions for handling custom currency operations", however I can only find one method.
  • The Script Include is missing a JavaScript comment about its purpose
  • The contained method is missing a JavaScript comment about its purpose
  • Extra tip: The return value of method "getReferenceValue" is badly designed: a boolean value is not an object and thus leading to broken code on the consumer side!

Please fix the mentioned issues and provide more detailed and specific information about the modifications, the reason behind them, and their expected impact. This will help in better understanding and reviewing your contribution effectively. Closing this for now. Once you make additional changes, feel free to re-open this Pull Request or create a new one.

@mskoddow mskoddow closed this Oct 1, 2025
@mskoddow
Copy link
Contributor

mskoddow commented Oct 1, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants