Raymond/gelu act #399
Draft
Raymond/gelu act #399
+5
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlamypoirier
reviewed
Dec 2, 2025
| An enum for the available activation types for the MLP layer. | ||
| """ | ||
|
|
||
| gelu_gaussian = "gelu_gaussian" |
Collaborator
There was a problem hiding this comment.
There is no point in having a separate gelu because we're not going for exact numerical match, and we already have bigger numerical differences anyway. HF gelu and gelu_pytorch_tanh should both map to our standard gelu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ Description
Small changes to be able to load Apriel-1.5-15B:
projector_intermediate_sizefrom llava_hybrid and llava convertergeluactivation