Skip to content

1398 Improve performance in apply_mobility #1399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

1398 Improve performance in apply_mobility #1399

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fed4653
Remove if condition
julianlitz Oct 20, 2025
6d300b6
Check iterator validity before using in mobility calculation
julianlitz Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions cpp/memilio/mobility/metapopulation_mobility_instant.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -601,7 +601,8 @@ void mio::MobilityEdge<FP>::apply_mobility(FP t, FP dt, SimulationNode<FP, Sim>&
for (Eigen::Index i = m_return_times.get_num_time_points() - 1; i >= 0; --i) {
if (m_return_times.get_time(i) <= t) {
auto v0 = find_value_reverse<FP>(node_to.get_result(), m_mobile_population.get_time(i), 1e-10, 1e-10);
assert(v0 != node_to.get_result().rend() && "unexpected error.");
if (v0 == node_to.get_result().rend())
continue;
calculate_mobility_returns<FP, Sim>(m_mobile_population[i], node_to.get_simulation(), *v0,
m_mobile_population.get_time(i), dt);

Expand Down Expand Up @@ -634,8 +635,7 @@ void mio::MobilityEdge<FP>::apply_mobility(FP t, FP dt, SimulationNode<FP, Sim>&
}
}

if (!m_return_mobile_population &&
(m_parameters.get_coefficients().get_matrix_at(SimulationTime<FP>(t)).array() > 0.0).any()) {
if (!m_return_mobile_population) {
//normal daily mobility
m_mobile_population.add_time_point(
t, (node_from.get_last_state().array() *
Expand Down