Skip to content

[SYNPY-1681] Set JSON Schema type based on columnType; remove type setting via validation rules #1274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 26 commits into from
Nov 11, 2025
Merged

[SYNPY-1681] Set JSON Schema type based on columnType; remove type setting via validation rules #1274

Show file tree
Hide file tree
Changes from 18 commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
4701577
move a lot of files and functions; remove concept of explict js type;…
Nov 7, 2025
7a49707
move a lot of files and functions; remove concept of explict js type;…
Nov 7, 2025
2a6e17f
move more json files; add a mini version of Metadata class
Nov 7, 2025
336b781
looks like get component requirement is not needed
Nov 7, 2025
810d95d
remove df_utils, import load_df from schema_generation
Nov 7, 2025
589db6b
make sure if setup.cfg changes, the dependencies get reinstalled
Nov 7, 2025
5bff42b
reorganize test and test dirs in the code
Nov 7, 2025
0e216f9
update cmments
Nov 7, 2025
67e8728
add back example model jsonld
Nov 7, 2025
41c5184
rewrite some tests using dmge_column_type
Nov 10, 2025
8a26146
remove unused comment
Nov 10, 2025
71ae547
trim down the helpper function
Nov 10, 2025
4a73fa5
update the reason
Nov 10, 2025
1391983
remove js_type in _get_validation_rule_based_fields
Nov 10, 2025
e96e87f
remove js type in ValidationRule
Nov 10, 2025
699e543
completely remove get_js_type_from_inputted_rules
Nov 10, 2025
09d3c7f
replace node2 with traversal node
Nov 10, 2025
4cf904f
completely remove node2
Nov 10, 2025
626b06e
remove type validation rule name
Nov 10, 2025
c8758f7
abolish jsonschema type
Nov 10, 2025
b6a8340
remove comment
Nov 10, 2025
fe48b08
revert changes to the json schema type
Nov 10, 2025
1872909
updated dmge to use get_validation_rule_based_fields_no_explicit_type
Nov 10, 2025
1d6abfc
delete temporary files generated by unit test
Nov 10, 2025
abb7540
remove unused import
Nov 11, 2025
3ef114f
simply just use the key to v29 like other PRs
Nov 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ jobs:
path: |
${{ steps.get-dependencies.outputs.site_packages_loc }}
${{ steps.get-dependencies.outputs.site_bin_dir }}
key: ${{ runner.os }}-${{ matrix.python }}-build-${{ env.cache-name }}-${{ hashFiles('setup.py') }}-v28
key: ${{ runner.os }}-${{ matrix.python }}-build-${{ env.cache-name }}-${{ hashFiles('setup.py', 'setup.cfg') }}-v28
Copy link
Contributor Author

@linglp linglp Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure that CI/CD reinstall dependencies if setup.cfg changes.


- name: Install py-dependencies
if: steps.cache-dependencies.outputs.cache-hit != 'true'
Expand Down
2 changes: 2 additions & 0 deletions setup.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,8 @@ curator =
networkx>=2.2.8
dataclasses-json>=0.6.1
rdflib>=6.0.0
jsonschema>=4.23.0
Copy link
Contributor Author

@linglp linglp Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this library is also required for the curator extension. We did the following in the test:

from jsonschema import Draft7Validator
from jsonschema.exceptions import ValidationError



pysftp =
pysftp>=0.2.8,<0.3
Expand Down
Loading
Loading